Sign upLogin

eveseat/web

View on GitHub
Star
src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php

Summary

Maintainability
B
6 hrs
Test Coverage

Avoid too many return statements within this method.
Open

                return ($row->location_flag == 'AutoFit' && $row->location_type == 'solar_system') ? 'In Space' : '';
Severity: Major
Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return $this->divisions->where('division', 5)->first()->name ?? sprintf('%s 5', trans_choice('web::assets.division', 1));
    Severity: Major
    Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->divisions->where('division', 6)->first()->name ?? sprintf('%s 6', trans_choice('web::assets.division', 1));
      Severity: Major
      Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->divisions->where('division', 7)->first()->name ?? sprintf('%s 7', trans_choice('web::assets.division', 1));
        Severity: Major
        Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return 'Delivery Hangar';
          Severity: Major
          Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php - About 30 mins to fix

            The method draw() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
            Open

                public function draw(Model $row)
    {
        switch ($row->location_flag) {
            case 'CorpSAG1':
                return $this->divisions->where('division', 1)->first()->name ?? sprintf('%s 1', trans_choice('web::assets.division', 1));
            Severity: Minor
            Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                public function search($query, string $keyword)
    {
        $divisions = $this->divisions->filter(function ($division) use ($keyword) {
            return strpos(strtolower($division->name), strtolower($keyword)) !== false;
        })->map(function ($division) {
            Severity: Major
            Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/LocationFlag.php and 1 other location - About 3 hrs to fix
            src/Http/DataTables/Corporation/Industrial/Blueprints/Columns/LocationFlag.php on lines 89..101

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 161.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status