Sign upLogin

eveseat/web

View on GitHub
Star
src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php

Summary

Maintainability
C
1 day
Test Coverage

Function getLocationNameFromDivision has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    private function getLocationNameFromDivision(CorporationAsset $item)
    {
        // item > division > office > station / structure
        if (in_array($item->container->location_flag, ['Impounded', 'OfficeFolder'])) {
            if ($item->container->location_type == 'station')
Severity: Minor
Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function draw has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function draw(Model $row)
    {
        if ($row->location_type == 'station')
            return $row->station->name;
Severity: Minor
Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return $item->container->station->name;
Severity: Major
Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return $row->name;
    Severity: Major
    Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return $item->structure->name;
      Severity: Major
      Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return sprintf('%d (%d)', $item->item_id, $item->location_id);
        Severity: Major
        Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $item->station->name;
          Severity: Major
          Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return sprintf('%d (%d)', $row->item_id, $row->location_id);
            Severity: Major
            Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php - About 30 mins to fix

              The method getLocationNameFromDivision() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
              Open

                  private function getLocationNameFromDivision(CorporationAsset $item)
    {
        // item > division > office > station / structure
        if (in_array($item->container->location_flag, ['Impounded', 'OfficeFolder'])) {
            if ($item->container->location_type == 'station')
              Severity: Minor
              Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      $query->orWhereHas('container.container', function ($container) use ($keyword) {
            $container->whereRaw('name LIKE ?', ["%{$keyword}%"]);
        })->orWhereHas('container.container.station', function ($station) use ($keyword) {
            $station->whereRaw('name LIKE ?', ["%{$keyword}%"]);
        })->orWhereHas('container.container.structure', function ($structure) use ($keyword) {
              Severity: Major
              Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php and 3 other locations - About 2 hrs to fix
              src/Http/DataTables/Character/Intel/Assets/Columns/Station.php on lines 111..117
              src/Http/DataTables/Common/Intel/AbstractAssetDataTable.php on lines 75..81
              src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php on lines 93..99

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      $query->orWhereHas('container', function ($container) use ($keyword) {
            $container->whereRaw('name LIKE ?', ["%{$keyword}%"]);
        })->orWhereHas('container.station', function ($station) use ($keyword) {
            $station->whereRaw('name LIKE ?', ["%{$keyword}%"]);
        })->orWhereHas('container.structure', function ($structure) use ($keyword) {
              Severity: Major
              Found in src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php and 3 other locations - About 2 hrs to fix
              src/Http/DataTables/Character/Intel/Assets/Columns/Station.php on lines 111..117
              src/Http/DataTables/Common/Intel/AbstractAssetDataTable.php on lines 75..81
              src/Http/DataTables/Corporation/Intel/Assets/Columns/Station.php on lines 103..109

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 123.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status