src/Http/DataTables/Scopes/CharacterNoteScope.php from eveseat/web

src/Http/DataTables/Scopes/CharacterNoteScope.php

Summary

Maintainability

7 hrs

Test Coverage

Method `apply` has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function apply($query)
    {
        if ($this->requested_characters != null) {
            $character_ids = collect($this->requested_characters)->filter(function ($item) {
                return Gate::allows('character.intel', [$item]);

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php - About 2 hrs to fix

Avoid too many `return` statements within this method.
Open

            return $query;

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return $query->whereIntegerInRaw('object_id', $character_ids);

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

            return [
                'characters'   => collect($filters->character ?? [])->pluck('id')->toArray(),
                'corporations' => collect($filters->corporation ?? [])->pluck('id')->toArray(),
                'alliances'    => collect($filters->alliance ?? [])->pluck('id')->toArray(),
            ];

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        if ($permissions->filter(function ($permission) { return ! $permission->hasFilters(); })->isNotEmpty())

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php - About 30 mins to fix

Identical blocks of code found in 7 locations. Consider refactoring.
Open

        $map = $permissions->map(function ($permission) {
            $filters = json_decode($permission->pivot->filters);

            return [
                'characters'   => collect($filters->character ?? [])->pluck('id')->toArray(),

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php and 6 other locations - About 2 hrs to fix

Read up
Read up

src/Http/Controllers/Character/MailController.php on lines 160..168

src/Http/DataTables/Scopes/CharacterMailScope.php on lines 90..98

src/Http/DataTables/Scopes/CharacterScope.php on lines 103..111

src/Http/DataTables/Scopes/KillMailCharacterScope.php on lines 95..103

src/Http/Validation/StandingsExistingElementAdd.php on lines 110..118

src/Http/Validation/StandingsExistingElementAdd.php on lines 159..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $director_roles_corporations. Keep variable name length under 20.
Open

        $director_roles_corporations = CorporationRole::whereIn('corporation_id', $associated_corporations)->whereIn('character_id', $owned_range)

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_ceo_corporations. Keep variable name length under 20.
Open

        $associated_ceo_corporations = CorporationInfo::whereIn('ceo_id', $owned_range)->get();

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_corporations. Keep variable name length under 20.
Open

        $associated_corporations = auth()->user()->characters->load('affiliation')->pluck('affiliation.corporation_id')->values()->toArray();

Found in src/Http/DataTables/Scopes/CharacterNoteScope.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

eveseat/web

Summary

Maintainability

Test Coverage

Method apply has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Identical blocks of code found in 7 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid excessively long variable names like $director_corporations. Keep variable name length under 20. Open

LongVariable

Since: 0.2

Example

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $director_roles_corporations. Keep variable name length under 20. Open

LongVariable

Since: 0.2

Example

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_ceo_corporations. Keep variable name length under 20. Open

LongVariable

Since: 0.2

Example

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $associated_corporations. Keep variable name length under 20. Open

LongVariable

Since: 0.2

Example

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category

Status

Method `apply` has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Identical blocks of code found in 7 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Avoid excessively long variable names like $director_corporations. Keep variable name length under 20.
Open

Avoid excessively long variable names like $director_roles_corporations. Keep variable name length under 20.
Open

Avoid excessively long variable names like $associated_ceo_corporations. Keep variable name length under 20.
Open

Avoid excessively long variable names like $associated_corporations. Keep variable name length under 20.
Open