src/Http/Validation/RolePermission.php
Method rules has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function rules()
{
// Start with a default rules array for the
// role_id checkAvoid too many return statements within this method. Open
Open
return $rules;The method rules uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
// If the string does not have . notation,
// then we can assume its flat and no category needs
// appending to the permission name- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}