eveseat/web

Method addCharacterPermissionScope has 29 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function addCharacterPermissionScope($query, string $ability)
    {
        if (auth()->user()->isAdmin())
            return $query;

Method addCorporationPermissionScope has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function addCorporationPermissionScope($query, string $ability)
    {
        if (auth()->user()->isAdmin())
            return $query;

Avoid too many return statements within this method.

Open

        return $query->where(function ($sub_query) use ($characters_range, $corporations_range, $alliances_range) {
            return $sub_query->whereIn('ceo_id', $characters_range)
                ->orWhereIn('alliance_id', $alliances_range)
                ->orWhereIn('corporation_id', $corporations_range);
        });

Avoid too many return statements within this method.

Open

            return [
                'characters'   => collect($filters->character ?? [])->pluck('id')->toArray(),
                'corporations' => collect($filters->corporation ?? [])->pluck('id')->toArray(),
                'alliances'    => collect($filters->alliance ?? [])->pluck('id')->toArray(),
            ];

Avoid too many return statements within this method.

Open

        return $query->where(function ($sub_query) use ($map) {
            $character_ids = array_merge(
                auth()->user()->associatedCharacterIds(),
                $map->pluck('characters')->flatten()->toArray(),
            );

Avoid too many return statements within this method.

Open

            return [
                'characters'   => collect($filters->character ?? [])->pluck('id')->toArray(),
                'corporations' => collect($filters->corporation ?? [])->pluck('id')->toArray(),
                'alliances'    => collect($filters->alliance ?? [])->pluck('id')->toArray(),
            ];

Identical blocks of code found in 7 locations. Consider refactoring.

Open

        $map = $permissions->map(function ($permission) {
            $filters = json_decode($permission->pivot->filters);

            return [
                'characters'   => collect($filters->character ?? [])->pluck('id')->toArray(),

• Read up
  Read up

Identical blocks of code found in 7 locations. Consider refactoring.

Open

        $map = $permissions->map(function ($permission) {
            $filters = json_decode($permission->pivot->filters);

            return [
                'characters'   => collect($filters->character ?? [])->pluck('id')->toArray(),

• Read up
  Read up