Sign upLogin

exercism/website

View on GitHub
Star
app/javascript/components/settings/CommunicationPreferencesForm.tsx

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      {preferences.mentoring.map((p) => (
        <label className="c-checkbox-wrapper" key={p.key}>
          <input
            type="checkbox"
            checked={p.value}
Severity: Major
Found in app/javascript/components/settings/CommunicationPreferencesForm.tsx and 2 other locations - About 5 hrs to fix
app/javascript/components/settings/CommunicationPreferencesForm.tsx on lines 81..95
app/javascript/components/settings/UserPreferencesForm.tsx on lines 67..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      {preferences.product.map((p) => (
        <label className="c-checkbox-wrapper" key={p.key}>
          <input
            type="checkbox"
            checked={p.value}
Severity: Major
Found in app/javascript/components/settings/CommunicationPreferencesForm.tsx and 2 other locations - About 5 hrs to fix
app/javascript/components/settings/CommunicationPreferencesForm.tsx on lines 65..79
app/javascript/components/settings/UserPreferencesForm.tsx on lines 67..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 139.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  const handlePreferenceChange = useCallback(
    (changedPreference, key: keyof CommunicationPreferences) => {
      return (e: React.ChangeEvent<HTMLInputElement>) => {
        setPreferences({
          ...preferences,
Severity: Major
Found in app/javascript/components/settings/CommunicationPreferencesForm.tsx and 1 other location - About 4 hrs to fix
app/javascript/components/settings/UserPreferencesForm.tsx on lines 48..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 121.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

      <div className="form-footer">
        <FormButton status={status} className="btn-primary btn-m">
          Change preferences
        </FormButton>
        <FormMessage
Severity: Major
Found in app/javascript/components/settings/CommunicationPreferencesForm.tsx and 5 other locations - About 2 hrs to fix
app/javascript/components/settings/HandleForm.tsx on lines 83..93
app/javascript/components/settings/ProfileForm.tsx on lines 148..158
app/javascript/components/settings/PronounsForm.tsx on lines 140..150
app/javascript/components/settings/TokenForm.tsx on lines 52..62
app/javascript/components/settings/UserPreferencesForm.tsx on lines 82..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

const SuccessMessage = () => {
  return (
    <div className="status success">
      <Icon icon="completed-check-circle" alt="Success" />
      Your preferences have been updated
Severity: Major
Found in app/javascript/components/settings/CommunicationPreferencesForm.tsx and 6 other locations - About 40 mins to fix
app/javascript/components/settings/HandleForm.tsx on lines 98..105
app/javascript/components/settings/ProfileForm.tsx on lines 163..170
app/javascript/components/settings/PronounsForm.tsx on lines 155..162
app/javascript/components/settings/TokenForm.tsx on lines 67..74
app/javascript/components/settings/UserPreferencesForm.tsx on lines 97..104
app/javascript/components/settings/comments-preference-form/CommentsPreferenceForm.tsx on lines 97..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status