Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/controllers/menu_items_controller.rb

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Class has too many lines. [143/100]
Open

class MenuItemsController < ApplicationController
  def action_allowed?
    case params[:action]
    when 'link'
      true
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for update is too high. [34.1/15]
Open

  def update
    # Flash an error if neither an action nor a page has been selected
    if params[:menu_item][:controller_action_id].blank? &&
       params[:menu_item][:content_page_id].blank?
      flash[:error] = 'You must specify either an action or a page!'
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [24/10]
Open

  def update
    # Flash an error if neither an action nor a page has been selected
    if params[:menu_item][:controller_action_id].blank? &&
       params[:menu_item][:content_page_id].blank?
      flash[:error] = 'You must specify either an action or a page!'
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [29.98/15]
Open

  def create
    # Flash an error if neither an action nor a page has been selected
    if params[:menu_item][:controller_action_id].blank? &&
       params[:menu_item][:content_page_id].blank?
      flash[:error] = 'You must specify either an action or a page!'
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [20/10]
Open

  def create
    # Flash an error if neither an action nor a page has been selected
    if params[:menu_item][:controller_action_id].blank? &&
       params[:menu_item][:content_page_id].blank?
      flash[:error] = 'You must specify either an action or a page!'
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for update is too high. [8/7]
Open

  def update
    # Flash an error if neither an action nor a page has been selected
    if params[:menu_item][:controller_action_id].blank? &&
       params[:menu_item][:content_page_id].blank?
      flash[:error] = 'You must specify either an action or a page!'
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method update has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    # Flash an error if neither an action nor a page has been selected
    if params[:menu_item][:controller_action_id].blank? &&
       params[:menu_item][:content_page_id].blank?
      flash[:error] = 'You must specify either an action or a page!'
Severity: Minor
Found in app/controllers/menu_items_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def move_up
    @menu_item = MenuItem.find(params[:id])
    @above = @menu_item.above

    if @above
Severity: Minor
Found in app/controllers/menu_items_controller.rb and 1 other location - About 35 mins to fix
app/controllers/menu_items_controller.rb on lines 124..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def move_down
    @menu_item = MenuItem.find(params[:id])
    @below = @menu_item.below

    if @below
Severity: Minor
Found in app/controllers/menu_items_controller.rb and 1 other location - About 35 mins to fix
app/controllers/menu_items_controller.rb on lines 112..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Missing top-level class documentation comment.
Open

class MenuItemsController < ApplicationController
Severity: Minor
Found in app/controllers/menu_items_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status