Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/controllers/notifications_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
F
0%

Method has too many lines. [11/10]
Open

  def create
    if params[:notification]
      redirect_back fallback_location: root_path
      return
    end
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if current_user.try(:student?)
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Missing top-level class documentation comment.
Open

class NotificationsController < ApplicationController
Severity: Minor
Found in app/controllers/notifications_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status