expertiza/expertiza

View on GitHub
app/helpers/authorization_helper.rb

Summary

Maintainability
A
2 hrs
Test Coverage
F
34%

Module has too many lines. [119/100]
Open

module AuthorizationHelper
  # Notes:
  # We use session directly instead of current_role_name and the like
  # Because helpers do not seem to have access to the methods defined in app/controllers/application_controller.rb

Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop checks if the length a module exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for response_edit_allowed? is too high. [24.78/15]
Open

  def response_edit_allowed?(map, user_id)
    assignment = map.reviewer.assignment
    # if it is a review response map, all the members of reviewee team should be able to view the response (can be done from heat map)
    if map.is_a? ReviewResponseMap
      reviewee_team = AssignmentTeam.find(map.reviewee_id)
Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for response_edit_allowed? is too high. [14/6]
Open

  def response_edit_allowed?(map, user_id)
    assignment = map.reviewer.assignment
    # if it is a review response map, all the members of reviewee team should be able to view the response (can be done from heat map)
    if map.is_a? ReviewResponseMap
      reviewee_team = AssignmentTeam.find(map.reviewee_id)
Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for response_edit_allowed? is too high. [14/7]
Open

  def response_edit_allowed?(map, user_id)
    assignment = map.reviewer.assignment
    # if it is a review response map, all the members of reviewee team should be able to view the response (can be done from heat map)
    if map.is_a? ReviewResponseMap
      reviewee_team = AssignmentTeam.find(map.reviewee_id)
Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method has too many lines. [15/10]
Open

  def response_edit_allowed?(map, user_id)
    assignment = map.reviewer.assignment
    # if it is a review response map, all the members of reviewee team should be able to view the response (can be done from heat map)
    if map.is_a? ReviewResponseMap
      reviewee_team = AssignmentTeam.find(map.reviewee_id)
Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [12/10]
Open

  def given_user_can?(user_id, action)
    participant = Participant.find_by(id: user_id)
    return false if participant.nil?

    case action
Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for current_user_instructs_assignment? is too high. [16.49/15]
Open

  def current_user_instructs_assignment?(assignment)
    user_logged_in? && !assignment.nil? && (
      assignment.instructor_id == session[:user].id ||
      (assignment.course_id && Course.find(assignment.course_id).instructor_id == session[:user].id)
    )
Severity: Minor
Found in app/helpers/authorization_helper.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Consider simplifying this complex logical expression.
Open

    if map.is_a? ReviewResponseMap
      reviewee_team = AssignmentTeam.find(map.reviewee_id)
      return user_logged_in? &&
             (
               current_user_has_id?(user_id) ||
Severity: Critical
Found in app/helpers/authorization_helper.rb - About 1 hr to fix

    Method response_edit_allowed? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def response_edit_allowed?(map, user_id)
        assignment = map.reviewer.assignment
        # if it is a review response map, all the members of reviewee team should be able to view the response (can be done from heat map)
        if map.is_a? ReviewResponseMap
          reviewee_team = AssignmentTeam.find(map.reviewee_id)
    Severity: Minor
    Found in app/helpers/authorization_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Align ) with (.
    Open

            )
    Severity: Minor
    Found in app/helpers/authorization_helper.rb by rubocop

    This cops checks the indentation of hanging closing parentheses in method calls, method definitions, and grouped expressions. A hanging closing parenthesis means ) preceded by a line break.

    Example:

    # good: when x is on its own line, indent this way
    func(
      x,
      y
    )
    
    # good: when x follows opening parenthesis, align parentheses
    a = b * (x +
             y
            )
    
    # bad
    def func(
      x,
      y
      )
    end

    Missing top-level module documentation comment.
    Open

    module AuthorizationHelper
    Severity: Minor
    Found in app/helpers/authorization_helper.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    There are no issues that match your filters.

    Category
    Status