expertiza/expertiza

View on GitHub
app/models/course_node.rb

Summary

Maintainability
A
2 hrs
Test Coverage
C
78%

Method has too many lines. [15/10]
Open

  def self.get_course_query_conditions(show = nil, user_id = nil)
    current_user = User.find_by(id: user_id)
    conditions = if show && current_user
                   if current_user.teaching_assistant? == false
                     "courses.instructor_id = #{user_id}"
Severity: Minor
Found in app/models/course_node.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Perceived complexity for get_course_query_conditions is too high. [8/7]
Open

  def self.get_course_query_conditions(show = nil, user_id = nil)
    current_user = User.find_by(id: user_id)
    conditions = if show && current_user
                   if current_user.teaching_assistant? == false
                     "courses.instructor_id = #{user_id}"
Severity: Minor
Found in app/models/course_node.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method get has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def self.get(_sortvar = 'name', _sortorder = 'desc', user_id = nil, show = nil, _parent_id = nil, _search = nil)
Severity: Minor
Found in app/models/course_node.rb - About 45 mins to fix

    Method get_children has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def get_children(sortvar = nil, sortorder = nil, user_id = nil, show = nil, _parent_id = nil, search = nil)
    Severity: Minor
    Found in app/models/course_node.rb - About 45 mins to fix

      Method get_course_query_conditions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.get_course_query_conditions(show = nil, user_id = nil)
          current_user = User.find_by(id: user_id)
          conditions = if show && current_user
                         if current_user.teaching_assistant? == false
                           "courses.instructor_id = #{user_id}"
      Severity: Minor
      Found in app/models/course_node.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid parameter lists longer than 5 parameters. [6/5]
      Open

        def get_children(sortvar = nil, sortorder = nil, user_id = nil, show = nil, _parent_id = nil, search = nil)
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

      Avoid parameter lists longer than 5 parameters. [6/5]
      Open

        def self.get(_sortvar = 'name', _sortorder = 'desc', user_id = nil, show = nil, _parent_id = nil, _search = nil)
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

      Do not prefix reader method names with get_.
      Open

        def get_teams
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Do not prefix reader method names with get_.
      Open

        def get_modified_date
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Missing top-level class documentation comment.
      Open

      class CourseNode < Node
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

      The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

      Example:

      # bad
      class Person
        # ...
      end
      
      # good
      # Description/Explanation of Person class
      class Person
        # ...
      end

      Use a guard clause instead of wrapping the code inside a conditional expression.
      Open

          if Course.column_names.include? sortvar
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      Use a guard clause instead of wrapping the code inside a conditional expression

      Example:

      # bad
      def test
        if something
          work
        end
      end
      
      # good
      def test
        return unless something
        work
      end
      
      # also good
      def test
        work if something
      end
      
      # bad
      if something
        raise 'exception'
      else
        ok
      end
      
      # good
      raise 'exception' if something
      ok

      Do not prefix reader method names with get_.
      Open

        def self.get_parent_id
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Do not prefix reader method names with get_.
      Open

        def get_private
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Convert if nested inside else to elsif.
      Open

                         if current_user.teaching_assistant? == false
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      If the else branch of a conditional consists solely of an if node, it can be combined with the else to become an elsif. This helps to keep the nesting level from getting too deep.

      Example:

      # bad
      if condition_a
        action_a
      else
        if condition_b
          action_b
        else
          action_c
        end
      end
      
      # good
      if condition_a
        action_a
      elsif condition_b
        action_b
      else
        action_c
      end

      Do not prefix reader method names with get_.
      Open

        def get_name
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Do not prefix reader method names with get_.
      Open

        def get_directory
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Do not prefix reader method names with get_.
      Open

        def get_instructor_id
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Do not prefix reader method names with get_.
      Open

        def get_creation_date
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      Do not prefix reader method names with get_.
      Open

        def get_survey_distribution_id
      Severity: Minor
      Found in app/models/course_node.rb by rubocop

      This cop makes sure that accessor methods are named properly.

      Example:

      # bad
      def set_attribute(value)
      end
      
      # good
      def attribute=(value)
      end
      
      # bad
      def get_attribute
      end
      
      # good
      def attribute
      end

      There are no issues that match your filters.

      Category
      Status