Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/models/metareview_response_map.rb

Summary

Maintainability
A
2 hrs
Test Coverage
B
83%

Assignment Branch Condition size for import is too high. [51.83/15]
Open

  def self.import(row_hash, _session, id)
    raise ArgumentError, 'Not enough items. The string should contain: Author, Reviewer, ReviewOfReviewer1 <, ..., ReviewerOfReviewerN>' if row_hash.length < 3

    row_hash[:metareviewers].each do |row|
      # ACS Make All contributors as teams
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [15/10]
Open

  def get_all_versions
    if review_mapping.response
      @sorted_array = []
      @prev = Response.all
      @prev.each do |element|
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [15/10]
Open

  def self.import(row_hash, _session, id)
    raise ArgumentError, 'Not enough items. The string should contain: Author, Reviewer, ReviewOfReviewer1 <, ..., ReviewerOfReviewerN>' if row_hash.length < 3

    row_hash[:metareviewers].each do |row|
      # ACS Make All contributors as teams
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for export is too high. [19.1/15]
Open

  def self.export(csv, parent_id, _options)
    mappings = Assignment.find(parent_id).metareview_mappings
    mappings = mappings.sort_by { |a| [a.review_mapping.reviewee.name, a.reviewee.name, a.reviewer.name] }
    mappings.each do |map|
      csv << [
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for get_all_versions is too high. [17.03/15]
Open

  def get_all_versions
    if review_mapping.response
      @sorted_array = []
      @prev = Response.all
      @prev.each do |element|
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for import is too high. [7/6]
Open

  def self.import(row_hash, _session, id)
    raise ArgumentError, 'Not enough items. The string should contain: Author, Reviewer, ReviewOfReviewer1 <, ..., ReviewerOfReviewerN>' if row_hash.length < 3

    row_hash[:metareviewers].each do |row|
      # ACS Make All contributors as teams
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method import has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def self.import(row_hash, _session, id)
    raise ArgumentError, 'Not enough items. The string should contain: Author, Reviewer, ReviewOfReviewer1 <, ..., ReviewerOfReviewerN>' if row_hash.length < 3

    row_hash[:metareviewers].each do |row|
      # ACS Make All contributors as teams
Severity: Minor
Found in app/models/metareview_response_map.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_all_versions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def get_all_versions
    if review_mapping.response
      @sorted_array = []
      @prev = Response.all
      @prev.each do |element|
Severity: Minor
Found in app/models/metareview_response_map.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Do not prefix reader method names with get_.
Open

  def get_all_versions
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

    if review_mapping.response
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Do not prefix reader method names with get_.
Open

  def get_title
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

Missing top-level class documentation comment.
Open

class MetareviewResponseMap < ResponseMap
Severity: Minor
Found in app/models/metareview_response_map.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status