Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/models/rscore.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Assignment Branch Condition size for initialize is too high. [33.78/15]
Open

  def initialize(my_score, type)
    @my_max = my_score[type][:scores][:max] == -1 ||  my_score[type][:scores][:max].nil? ? 'N/A' : my_score[type][:scores][:max]
    @my_min = my_score[type][:scores][:min] == -1 ||  my_score[type][:scores][:min].nil? ? 'N/A' : my_score[type][:scores][:min]
    @my_avg = my_score[type][:scores][:avg] == -1 ||  my_score[type][:scores][:avg].nil? ? 'N/A' : my_score[type][:scores][:avg]
    @my_type = type
Severity: Minor
Found in app/models/rscore.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for initialize is too high. [7/6]
Open

  def initialize(my_score, type)
    @my_max = my_score[type][:scores][:max] == -1 ||  my_score[type][:scores][:max].nil? ? 'N/A' : my_score[type][:scores][:max]
    @my_min = my_score[type][:scores][:min] == -1 ||  my_score[type][:scores][:min].nil? ? 'N/A' : my_score[type][:scores][:min]
    @my_avg = my_score[type][:scores][:avg] == -1 ||  my_score[type][:scores][:avg].nil? ? 'N/A' : my_score[type][:scores][:avg]
    @my_type = type
Severity: Minor
Found in app/models/rscore.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def initialize(my_score, type)
    @my_max = my_score[type][:scores][:max] == -1 ||  my_score[type][:scores][:max].nil? ? 'N/A' : my_score[type][:scores][:max]
    @my_min = my_score[type][:scores][:min] == -1 ||  my_score[type][:scores][:min].nil? ? 'N/A' : my_score[type][:scores][:min]
    @my_avg = my_score[type][:scores][:avg] == -1 ||  my_score[type][:scores][:avg].nil? ? 'N/A' : my_score[type][:scores][:avg]
    @my_type = type
Severity: Minor
Found in app/models/rscore.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @my_max = my_score[type][:scores][:max] == -1 ||  my_score[type][:scores][:max].nil? ? 'N/A' : my_score[type][:scores][:max]
    @my_min = my_score[type][:scores][:min] == -1 ||  my_score[type][:scores][:min].nil? ? 'N/A' : my_score[type][:scores][:min]
Severity: Minor
Found in app/models/rscore.rb and 2 other locations - About 20 mins to fix
app/models/rscore.rb on lines 12..13
app/models/rscore.rb on lines 13..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @my_min = my_score[type][:scores][:min] == -1 ||  my_score[type][:scores][:min].nil? ? 'N/A' : my_score[type][:scores][:min]
    @my_avg = my_score[type][:scores][:avg] == -1 ||  my_score[type][:scores][:avg].nil? ? 'N/A' : my_score[type][:scores][:avg]
Severity: Minor
Found in app/models/rscore.rb and 2 other locations - About 20 mins to fix
app/models/rscore.rb on lines 11..12
app/models/rscore.rb on lines 13..14

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @my_avg = my_score[type][:scores][:avg] == -1 ||  my_score[type][:scores][:avg].nil? ? 'N/A' : my_score[type][:scores][:avg]
    @my_type = type
Severity: Minor
Found in app/models/rscore.rb and 2 other locations - About 20 mins to fix
app/models/rscore.rb on lines 11..12
app/models/rscore.rb on lines 12..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Missing top-level class documentation comment.
Open

class Rscore
Severity: Minor
Found in app/models/rscore.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status