expertiza/expertiza

View on GitHub
app/models/student_task.rb

Summary

Maintainability
B
4 hrs
Test Coverage
B
88%

Class StudentTask has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class StudentTask
  attr_accessor :assignment, :current_stage, :participant, :stage_deadline, :topic

  def initialize(args)
    @assignment = args[:assignment]
Severity: Minor
Found in app/models/student_task.rb - About 2 hrs to fix

    Method teamed_students has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.teamed_students(user, ip_address = nil)
        students_teamed = {}
        user.teams.each do |team|
          next unless team.is_a?(AssignmentTeam)
          # Teammates in calibration assignment should not be counted in teaming requirement.
    Severity: Minor
    Found in app/models/student_task.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    unexpected token error (Using Ruby 2.1 parser; configure using TargetRubyVersion parameter, under AllCops)
    Open

        participant.team&.most_recent_submission
    Severity: Minor
    Found in app/models/student_task.rb by rubocop

    There are no issues that match your filters.

    Category
    Status