Assignment Branch Condition size for assignment_tagging_progress is too high. [69.75/15] Open
def assignment_tagging_progress
teams = Team.where(parent_id: assignment_id)
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
questions_ids = questions.map(&:id)
user_answer_tagging = []- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method has too many lines. [38/10] Open
def assignment_tagging_progress
teams = Team.where(parent_id: assignment_id)
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
questions_ids = questions.map(&:id)
user_answer_tagging = []- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Assignment Branch Condition size for get_number_of_taggable_answers is too high. [23.28/15] Open
def get_number_of_taggable_answers(user_id)
team = Team.joins(:teams_users).where(team_users: { parent_id: assignment_id }, user_id: user_id)
responses = Response.joins(:response_maps).where(response_maps: { reviewed_object_id: assignment.id, reviewee_id: team.id })
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method assignment_tagging_progress has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def assignment_tagging_progress
teams = Team.where(parent_id: assignment_id)
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
questions_ids = questions.map(&:id)
user_answer_tagging = []- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method has too many lines. [11/10] Open
def get_number_of_taggable_answers(user_id)
team = Team.joins(:teams_users).where(team_users: { parent_id: assignment_id }, user_id: user_id)
responses = Response.joins(:response_maps).where(response_maps: { reviewed_object_id: assignment.id, reviewee_id: team.id })
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
- Read upRead up
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method assignment_tagging_progress has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def assignment_tagging_progress
teams = Team.where(parent_id: assignment_id)
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
questions_ids = questions.map(&:id)
user_answer_tagging = []Block has too many lines. [29/25] Open
teams.each do |team|
if assignment.varying_rubrics_by_round?
responses = []
1.upto(assignment.rounds_of_reviews).each do |round|
responses += ReviewResponseMap.get_responses_for_team_round(team, round)- Read upRead up
- Exclude checks
This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.
Method get_number_of_taggable_answers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def get_number_of_taggable_answers(user_id)
team = Team.joins(:teams_users).where(team_users: { parent_id: assignment_id }, user_id: user_id)
responses = Response.joins(:response_maps).where(response_maps: { reviewed_object_id: assignment.id, reviewee_id: team.id })
questions = Question.where(questionnaire_id: questionnaire.id, type: question_type)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing top-level class documentation comment. Open
class TagPromptDeployment < ApplicationRecord- Read upRead up
- Exclude checks
This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.
The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.
Example:
# bad
class Person
# ...
end
# good
# Description/Explanation of Person class
class Person
# ...
end