Sign upLogin

expertiza/expertiza

View on GitHub
Star
app/models/vm_question_response_row.rb

Summary

Maintainability
A
35 mins
Test Coverage
C
78%

Method has too many lines. [12/10]
Open

  def average_score_for_row
    row_average_score = 0.0
    no_of_columns = 0.0 # Counting reviews that are not null
    @score_row.each do |score|
      if score.score_value.is_a? Numeric
Severity: Minor
Found in app/models/vm_question_response_row.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def initialize(question_text, question_id, weight, question_max_score, seq)
Severity: Minor
Found in app/models/vm_question_response_row.rb - About 35 mins to fix

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

        unless no_of_columns.zero?
    Severity: Minor
    Found in app/models/vm_question_response_row.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

    There are no issues that match your filters.

    Category
    Status