Sign upLogin

expertiza/expertiza

View on GitHub
Star
spec/controllers/join_team_request_controller_spec.rb

Summary

Maintainability
A
1 hr
Test Coverage

Block has too many lines. [149/25]
Open

describe JoinTeamRequestsController do
  # Including the stubbed objects from the teams_shared.rb file
  include_context 'object initializations'
  # Including the shared method from the teams_shared.rb file
  include_context 'authorization check'
Severity: Minor
Found in spec/controllers/join_team_request_controller_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [45/25]
Open

  describe 'POST #create' do
    before(:each) do
      # Stubbing participant to receive an object with id = 1
      allow(Participant).to receive(:find).with('1').and_return(participant)
    end
Severity: Minor
Found in spec/controllers/join_team_request_controller_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    context 'when show is valid' do
      it 'will show particular student team given index' do
        allow(JoinTeamRequest).to receive(:find).and_return(join_team_request2)
        request_params = { action: 'show' }
        user_session = { user: ta }
Severity: Minor
Found in spec/controllers/join_team_request_controller_spec.rb and 2 other locations - About 35 mins to fix
spec/controllers/join_team_request_controller_spec.rb on lines 21..28
spec/controllers/join_team_request_controller_spec.rb on lines 31..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    context 'when the user does not have admin permissions' do
      it 'redirects to' do
        # Stubbing an object to receive .all method to give list of index
        allow(JoinTeamRequest).to receive(:all).and_return(join_team_request1)
        request_params = { action: 'index' }
Severity: Minor
Found in spec/controllers/join_team_request_controller_spec.rb and 2 other locations - About 35 mins to fix
spec/controllers/join_team_request_controller_spec.rb on lines 31..38
spec/controllers/join_team_request_controller_spec.rb on lines 44..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    context 'when the user does have admin permissions' do
      it 'routes to index page' do
        # Stubbing an object to receive .all method to give list of index
        allow(JoinTeamRequest).to receive(:all).and_return(join_team_request1)
        request_params = { action: 'index' }
Severity: Minor
Found in spec/controllers/join_team_request_controller_spec.rb and 2 other locations - About 35 mins to fix
spec/controllers/join_team_request_controller_spec.rb on lines 21..28
spec/controllers/join_team_request_controller_spec.rb on lines 44..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status