expertiza/expertiza

View on GitHub
spec/controllers/quiz_questionnaires_controller_spec.rb

Summary

Maintainability
C
1 day
Test Coverage
describe QuizQuestionnairesController do
  let(:questionnaire) do
    build(id: 1, name: 'questionnaire', ta_id: 8, course_id: 1, private: false, min_question_score: 0, max_question_score: 5, type: 'ReviewQuestionnaire')
  end
  let(:questionnaire) { build(:questionnaire) }
  let(:quiz_questionnaire) { build(:questionnaire, type: 'QuizQuestionnaire') }
  let(:review_questionnaire) { build(:questionnaire, type: 'ReviewQuestionnaire') }
  let(:question) { build(:question, id: 1) }
  let(:admin) { build(:admin) }
  let(:instructor) { build(:instructor, id: 6) }
  let(:instructor2) { build(:instructor, id: 66) }
  let(:student) { build(:student, id: 8609) }
  let(:ta) { build(:teaching_assistant, id: 8) }
  before(:each) do
    allow(Questionnaire).to receive(:find).with('1').and_return(questionnaire)
    stub_current_user(instructor, instructor.role.name, instructor.role)
  end

  def check_access(username)
    stub_current_user(username, username.role.name, username.role)
    expect(controller.send(:action_allowed?))
  end
  describe '#valid_quiz' do
    before(:each) do
      allow(Assignment).to receive_message_chain(:find, :num_quiz_questions).with('1').with(no_args).and_return(1)
    end

    context 'when user does not specify quiz name' do
      it 'returns message (Please specify quiz name (please do not use your name or id).)' do
        controller.params = { aid: 1,
                              questionnaire: { name: '' } }
        expect(controller.validate_quiz).to eq('Please specify quiz name (please do not use your name or id).')
      end
    end

    describe '#create and #save' do
      context 'when quiz is valid' do
        before(:each) do
          # create_quiz_questionnaire
          allow_any_instance_of(QuizQuestionnairesController).to receive(:validate_quiz).and_return('valid')
        end
        context 'when questionnaire type is QuizQuestionnaire' do
          it 'redirects to submitted_content#edit page' do
            request_params = { aid: 1,
                       pid: 1,
                       questionnaire: { name: 'Test questionnaire',
                                        type: 'QuizQuestionnaire',
                                        min_question_score: 0,
                                        max_question_score: 5 } }
            # create_questionnaire
            participant = double('Participant')
            allow(Participant).to receive(:find).with('1').and_return(participant)
            allow(AssignmentTeam).to receive(:team).with(participant).and_return(double('AssignmentTeam', rspid: 6))
            allow(AssignmentTeam).to receive(:team).with(participant).and_return(double('AssignmentTeam', id: 6))
            # allow(AssignmentTeam).to receive(:id).with(participant).and_return(double('AssignmentTeam', id: 6))
            allow_any_instance_of(QuizQuestionnairesController).to receive(:save_choices).with(1).and_return(true)
            # save
            allow_any_instance_of(QuizQuestionnairesController).to receive(:save_questions).with(1).and_return(true)
            allow_any_instance_of(QuizQuestionnairesController).to receive(:undo_link).with(any_args).and_return('')
            post :create, params: request_params
            expect(flash[:note]).to eq('The quiz was successfully created.')
            expect(response).to redirect_to('/submitted_content/1/edit')
            expect(controller.instance_variable_get(:@questionnaire).private).to eq false
            expect(controller.instance_variable_get(:@questionnaire).name).to eq 'Test questionnaire'
            expect(controller.instance_variable_get(:@questionnaire).min_question_score).to eq 0
            expect(controller.instance_variable_get(:@questionnaire).max_question_score).to eq 5
            expect(controller.instance_variable_get(:@questionnaire).type).to eq 'QuizQuestionnaire'
            expect(controller.instance_variable_get(:@questionnaire).instructor_id).to eq 6
          end
        end

        context 'when questionnaire type is QuizQuestionnaire and max_question_score value is negative' do
          it 'creates error: The maximum question score must be a positive integer.' do
            request_params = { aid: 1,
                       pid: 1,
                       questionnaire: { name: 'Test questionnaire',
                                        type: 'QuizQuestionnaire',
                                        min_question_score: -2,
                                        max_question_score: -1 } }
            # create_questionnaire
            participant = double('Participant')
            allow(Participant).to receive(:find).with('1').and_return(participant)
            allow(AssignmentTeam).to receive(:team).with(participant).and_return(double('AssignmentTeam', rspid: 6))
            allow(AssignmentTeam).to receive(:team).with(participant).and_return(double('AssignmentTeam', id: 6))
            # allow(AssignmentTeam).to receive(:id).with(participant).and_return(double('AssignmentTeam', id: 6))
            allow_any_instance_of(QuizQuestionnairesController).to receive(:save_choices).with(1).and_return(true)
            # save
            allow_any_instance_of(QuizQuestionnairesController).to receive(:save_questions).with(1).and_return(true)
            allow_any_instance_of(QuizQuestionnairesController).to receive(:undo_link).with(any_args).and_return('')
            request.env['HTTP_REFERER'] = 'www.google.com'
            post :create, params: request_params
            expect(flash[:error]).to eq('Minimum and/or maximum question score cannot be less than 0.')
            expect(response).to redirect_to('www.google.com')
          end
        end

        context 'when questionnaire type is QuizQuestionnaire and min_question_score value is negative' do
          it 'creates error: The minimum question score must be a positive integer.' do
            request_params = { aid: 1,
                       pid: 1,
                       questionnaire: { name: 'Test questionnaire',
                                        type: 'QuizQuestionnaire',
                                        min_question_score: 2,
                                        max_question_score: 1 } }
            # create_questionnaire
            participant = double('Participant')
            allow(Participant).to receive(:find).with('1').and_return(participant)
            allow(AssignmentTeam).to receive(:team).with(participant).and_return(double('AssignmentTeam', rspid: 6))
            allow(AssignmentTeam).to receive(:team).with(participant).and_return(double('AssignmentTeam', id: 6))
            # allow(AssignmentTeam).to receive(:id).with(participant).and_return(double('AssignmentTeam', id: 6))
            allow_any_instance_of(QuizQuestionnairesController).to receive(:save_choices).with(1).and_return(true)
            # save
            allow_any_instance_of(QuizQuestionnairesController).to receive(:save_questions).with(1).and_return(true)
            allow_any_instance_of(QuizQuestionnairesController).to receive(:undo_link).with(any_args).and_return('')
            request.env['HTTP_REFERER'] = 'www.google.com'
            post :create, params: request_params
            expect(flash[:error]).to eq('Maximum question score cannot be less than minimum question score.')
            expect(response).to redirect_to('www.google.com')
          end
        end

        context 'when questionnaire type is QuizQuestionnaire and max_question_score is less than min_question_score' do
          it 'creates error: The minimum question score must be less than the maximum.' do
            questionnaire.min_question_score = 3
            questionnaire.max_question_score = 1
            questionnaire.valid?
            expect(questionnaire.errors[:min_question_score]).to include('The minimum question score must be less than the maximum.')
          end
        end

        context 'when quiz is invalid and questionnaire type is QuizQuestionnaire' do
          it 'redirects to submitted_content#edit page' do
            request_params = { aid: 1,
                       pid: 1,
                       questionnaire: { name: 'test questionnaire',
                                        type: 'QuizQuestionnaire' } }
            # create_quiz_questionnaire
            allow_any_instance_of(QuizQuestionnairesController).to receive(:validate_quiz).and_return('Please select a correct answer for all questions')
            request.env['HTTP_REFERER'] = 'www.google.com'
            post :create, params: request_params
            expect(flash[:error]).to eq('Please select a correct answer for all questions')
            expect(response).to redirect_to('www.google.com')
          end
        end
      end

      describe '#view' do
        it 'renders questionnaires#view_quiz' do
          allow(Questionnaire).to receive(:find).with('1').and_return(double('Questionnaire'))
          allow(Participant).to receive(:find).with('1').and_return(double('Participant'))
          request_params = { id: 1, pid: 1 }
          get :view, params: request_params
          expect(response).to render_template(:view)
        end
      end

      describe '#new' do
        context 'when an assignment requires quiz' do
          before(:each) do
            @request_params = { aid: 1,
                        model: 'QuizQuestionnaire',
                        pid: 1,
                        private: 0 }
            @assignment = double('Assignment')
            allow(Assignment).to receive(:find).with('1').and_return(@assignment)
            allow(@assignment).to receive(:require_quiz?).and_return(true)
          end

          it 'renders questionnaires#new if current participant has a team' do
            team = double('AssignmentTeam')
            allow(AssignmentParticipant).to receive_message_chain(:find, :team).with('1').with(no_args).and_return(team)
            allow(@assignment).to receive(:topics?).and_return(true)
            allow(team).to receive(:topic).and_return(double(:SignUpTopic))
            get :new, params: @request_params
            expect(response).to render_template(:new_quiz)
          end

          it 'shows error message and redirects to submitted_content#view if current participant does not have a team' do
            allow(AssignmentParticipant).to receive_message_chain(:find, :team).with('1').with(no_args).and_return(nil)
            get :new, params: @request_params
            expect(flash[:error]).to eq('You should create or join a team first.')
            expect(response).to redirect_to('/submitted_content/view?id=1')
          end

          it 'shows error message and redirects to submitted_content#view if current participant have a team w/o topic' do
            team = double('AssignmentTeam')
            allow(AssignmentParticipant).to receive_message_chain(:find, :team).with('1').with(no_args).and_return(team)
            allow(@assignment).to receive(:topics?).and_return(true)
            allow(team).to receive(:topic).and_return(nil)
            get :new, params: @request_params
            expect(flash[:error]).to eq('Your team should have a topic.')
            expect(response).to redirect_to('/submitted_content/view?id=1')
          end
        end

        context 'when an assignment does not require quiz' do
          it 'shows error message and redirects to submitted_content#view' do
            request_params = { aid: 1,
                       model: 'QuizQuestionnaire',
                       pid: 1,
                       private: 0 }
            assignment = double('Assignment')
            allow(Assignment).to receive(:find).with('1').and_return(assignment)
            allow(assignment).to receive(:require_quiz?).and_return(false)
            get :new, params: request_params
            expect(flash[:error]).to eq('This assignment is not configured to use quizzes.')
            expect(response).to redirect_to('/submitted_content/view?id=1')
          end
        end
      end

      describe '#edit' do
        before(:each) do
          @questionnaire = double('Questionnaire')
          allow(Questionnaire).to receive(:find).with('1').and_return(@questionnaire)
        end

        context 'when current questionnaire is not taken by anyone' do
          it 'renders questionnaires#edit page' do
            stub_current_user(student, student.role.name, student.role) # action only permitted for Student role
            allow(@questionnaire).to receive(:taken_by_anyone?).and_return(false)
            request_params = { id: 1 }
            get :edit, params: request_params
            expect(response).to render_template(:edit)
          end
        end

        context 'when current questionnaire has been taken by someone' do
          it 'shows flash[:error] message and redirects to submitted_content#view page' do
            stub_current_user(student, student.role.name, student.role) # action only permitted for Student role
            allow(@questionnaire).to receive(:taken_by_anyone?).and_return(true)
            request_params = { id: 1, pid: 1 }
            get :edit, params: request_params
            expect(flash[:error]).to eq('Your quiz has been taken by one or more students; you cannot edit it anymore.')
            expect(response).to redirect_to('/submitted_content/view?id=1')
          end
        end
      end

      describe '#update' do
        context 'when @questionnaire is nil' do
          it 'redirects to submitted_content#view page' do
            allow(Questionnaire).to receive(:find).with('1').and_return(nil)
            request_params = { id: 1, pid: 1 }
            post :update, params: request_params
            expect(response).to redirect_to('/submitted_content/view?id=1')
          end
        end

        context 'when @questionnaire is not nil' do
          it 'updates all quiz questions and redirects to submitted_content#view page' do
            request_params = { id: 1,
                       pid: 1,
                       save: true,
                       questionnaire: { name: 'test questionnaire',
                                        instructor_id: 6,
                                        private: 0,
                                        min_question_score: 0,
                                        max_question_score: 5,
                                        type: 'ReviewQuestionnaire',
                                        display_type: 'Review',
                                        instructor_loc: '' },
                       question: { '1' => { txt: 'Q1' },
                                   '2' => { txt: 'Q2' },
                                   '3' => { txt: 'Q3' },
                                   '4' => { txt: 'Q4' } },
                       quiz_question_choices: { '1' => { MultipleChoiceRadio:
                                                          { :correctindex => 1,
                                                            '1' => { txt: 'a11' },
                                                            '2' => { txt: 'a12' },
                                                            '3' => { txt: 'a13' },
                                                            '4' => { txt: 'a14' } } },
                                                '2' => { TrueFalse: { '1' => { iscorrect: 'True' } } },
                                                '3' => { MultipleChoiceCheckbox:
                                                          { '1' => { iscorrect: '0', txt: 'a31' },
                                                            '2' => { iscorrect: '1', txt: 'a32' },
                                                            '3' => { iscorrect: '0', txt: 'a33' },
                                                            '4' => { iscorrect: '1', txt: 'a34' } } },
                                                '4' => { TrueFalse: { '1' => { iscorrect: 'False' } } } },
                       question_weights: { '1' => { txt: '1' },
                                           '2' => { txt: '1' },
                                           '3' => { txt: '1' },
                                           '4' => { txt: '1' } } }
            questionnaire = double('Questionnaire')
            allow(Questionnaire).to receive(:find).with('1').and_return(questionnaire)
            allow(questionnaire).to receive(:update_attributes).with(any_args).and_return(true)
            q1 = build(:question, id: 1, type: 'MultipleChoiceRadio')
            q2 = build(:question, id: 2, type: 'TrueFalse')
            q3 = build(:question, id: 3, type: 'MultipleChoiceCheckbox')
            q4 = build(:question, id: 4, type: 'TrueFalse')
            allow(Question).to receive(:find).with('1').and_return(q1)
            allow(Question).to receive(:find).with('2').and_return(q2)
            allow(Question).to receive(:find).with('3').and_return(q3)
            allow(Question).to receive(:find).with('4').and_return(q4)
            qc = double('QuizQuestionChoice')
            # quiz question choice for true/false question
            qc_tf = double('QuizQuestionChoice', txt: 'True')
            allow(QuizQuestionChoice).to receive(:where).with(question_id: '1').and_return([qc, qc, qc, qc])
            allow(QuizQuestionChoice).to receive(:where).with(question_id: '2').and_return([qc_tf])
            allow(QuizQuestionChoice).to receive(:where).with(question_id: '3').and_return([qc, qc, qc, qc])
            allow(QuizQuestionChoice).to receive(:where).with(question_id: '4').and_return([qc_tf])
            allow(q1).to receive(:save).and_return(true)
            allow(q2).to receive(:save).and_return(true)
            allow(q3).to receive(:save).and_return(true)
            allow(q4).to receive(:save).and_return(true)
            allow(qc).to receive(:update_attributes).with(any_args).and_return(true)
            allow(qc_tf).to receive(:update_attributes).with(any_args).and_return(true)
            post :update, params: request_params
            expect(response).to redirect_to('/submitted_content/view?id=1')
          end
        end
      end

      context 'when user does not specify a type for each question' do
        it 'returns message (Please select a type for each question)' do
          controller.params = { aid: 1,
                                questionnaire: { name: 'test questionnaire' } }
          expect(controller.validate_quiz).to eq('Please select a type for each question')
        end
      end

      context 'when user does not specify choice info for one question' do
        it 'returns message (Please select a correct answer for all questions)' do
          controller.params = { aid: 1,
                                questionnaire: { name: 'test questionnaire' },
                                question_type: { '1' => { type: 'TrueFalse' } },
                                new_question: { '1' => { iscorrect: 'True' } },
                                new_choices: { '1' => {} } }
          expect(controller.validate_quiz).to eq('Please select a correct answer for all questions')
        end
      end

      context 'when user specifies all necessary information' do
        it 'returns message (valid)' do
          controller.params = { aid: 1,
                                questionnaire: { name: 'test questionnaire' },
                                question_type: { '1' => { type: 'TrueFalse' } },
                                new_question: { '1' => { iscorrect: 'True' } },
                                new_choices: { '1' => { 'TrueFalse' => 'sth' } } }
          question = build(:question, type: 'TrueFalse')
          allow(TrueFalse).to receive(:create).with(txt: '', type: 'TrueFalse', break_before: true).and_return(question)
          allow(question).to receive(:isvalid).with('sth').and_return('valid')
          expect(controller.validate_quiz).to eq('valid')
        end
      end
    end

    describe '#save_choices' do
      it 'is able to save different kinds of quiz questions' do
        controller.params = { new_question: { '1' => 'q1', '2' => 'q2', '3' => 'q3', '4' => 'q4' },
                              new_choices: { '1' => { MultipleChoiceRadio: { '1' => { txt: 'a11', iscorrect: '3' },
                                                                             '2' => { txt: 'a12' }, '3' => { txt: 'a13' }, '4' => { txt: 'a14' } } },
                                             '2' => { TrueFalse: { '1' => { iscorrect: '0' } } },
                                             '3' => { MultipleChoiceCheckbox: { '1' => { iscorrect: '0', txt: 'a31' },
                                                                                '2' => { iscorrect: '1', txt: 'a32' },
                                                                                '3' => { iscorrect: '1', txt: 'a33' },
                                                                                '4' => { iscorrect: '0', txt: 'a34' } } },
                                             '4' => { TrueFalse: { '1' => { iscorrect: '1' } } } },
                              question_type: { '1' => { type: 'MultipleChoiceRadio' },
                                               '2' => { type: 'TrueFalse' },
                                               '3' => { type: 'MultipleChoiceCheckbox' },
                                               '4' => { type: 'TrueFalse' } } }
        q1 = build(:question, id: 1, type: 'MultipleChoiceRadio')
        q2 = build(:question, id: 2, type: 'TrueFalse')
        q3 = build(:question, id: 3, type: 'MultipleChoiceCheckbox')
        q4 = build(:question, id: 4, type: 'TrueFalse')
        allow(Question).to receive(:where).with(questionnaire_id: 1).and_return([q1, q2, q3, q4])
        expect { controller.send(:save_choices, 1) }.to change { QuizQuestionChoice.count }.from(0).to(12)
      end
    end
  end
end