Sign upLogin

expertiza/expertiza

View on GitHub
Star
spec/models/true_false_spec.rb

Summary

Maintainability
A
1 hr
Test Coverage

Block has too many lines. [39/25]
Open

describe TrueFalse do
  let(:true_false) { build(:true_false, id: 1) }
  describe '#edit' do
    it 'returns html' do
      qc1 = double('QuizQuestionChoice')
Severity: Minor
Found in spec/models/true_false_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    context 'when the question does not have text' do
      it 'returns "Please make sure all questions have text"' do
        allow(true_false).to receive(:txt).and_return('')
        questions = { '1' => { txt: 'question text', iscorrect: '1' }, '2' => { txt: 'question text', iscorrect: '0' } }
        expect(true_false.isvalid(questions)).to eq('Please make sure all questions have text')
Severity: Minor
Found in spec/models/true_false_spec.rb and 2 other locations - About 35 mins to fix
spec/models/true_false_spec.rb on lines 21..25
spec/models/true_false_spec.rb on lines 28..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    context 'when no right answer was selected' do
      it 'returns "Please select a correct answer for all questions"' do
        allow(true_false).to receive(:txt).and_return('Text')
        questions = { '1' => { txt: 'question text', iscorrect: '0' }, '2' => { txt: 'question text', iscorrect: '0' } }
        expect(true_false.isvalid(questions)).to eq('Please select a correct answer for all questions')
Severity: Minor
Found in spec/models/true_false_spec.rb and 2 other locations - About 35 mins to fix
spec/models/true_false_spec.rb on lines 14..18
spec/models/true_false_spec.rb on lines 21..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    context 'when the choice does not have text' do
      it 'returns "Please make sure every question has text for all options"' do
        allow(true_false).to receive(:txt).and_return('Text')
        questions = { '1' => { txt: '', iscorrect: '1' }, '2' => { txt: 'question text', iscorrect: '0' } }
        expect(true_false.isvalid(questions)).to eq('Please make sure every question has text for all options')
Severity: Minor
Found in spec/models/true_false_spec.rb and 2 other locations - About 35 mins to fix
spec/models/true_false_spec.rb on lines 14..18
spec/models/true_false_spec.rb on lines 28..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 35.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status