expressly/php-common

Address has 23 functions (exceeds 20 allowed). Consider refactoring.

Open

class Address extends ArraySerializeable
{
    const ADDRESS_BILLING = 'billing';
    const ADDRESS_SHIPPING = 'shipping';
    const ADDRESS_BOTH = 'both';

Avoid variables with short names like $b. Configured minimum length is 3.

Open

    public static function compare(Address $a, Address $b)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $a. Configured minimum length is 3.

Open

    public static function compare(Address $a, Address $b)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Expected 1 newline at end of file; 0 found

Open

}

• Exclude checks
  • Disable engine
  • Disable check