ezpaarse-project/ezpaarse

View on GitHub

Showing 291 of 291 total issues

Function mail has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  mail: function mail(options) {
    var opts = options || {};

    return {
      send: function (callback) {
Severity: Minor
Found in lib/mailer.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function (req, res, job, next) {
  job.logger?.verbose('Initializing alerts');

  var match;
  var actions       = req.header('ezPAARSE-Job-Notifications');
Severity: Minor
Found in lib/init/init-alerts.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function (req, res, job, next) {
  job.logger?.verbose('Initializing output fields');
  job.outputFields = job.outputFields || { added: [], removed: [] };

  var fieldsHeader = req.header('Output-Fields');
Severity: Minor
Found in lib/init/init-outputfields.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    SET_HEADER_NAME ({ commit }, { index, value }) {
      commit('SET_HEADER_NAME', { index, value });
    },
Severity: Minor
Found in client/store/settings.js and 1 other location - About 35 mins to fix
client/store/settings.js on lines 311..313

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    SET_HEADER_VALUE ({ commit }, { index, value }) {
      commit('SET_HEADER_VALUE', { index, value });
    },
Severity: Minor
Found in client/store/settings.js and 1 other location - About 35 mins to fix
client/store/settings.js on lines 308..310

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    if (!exports.equals(x[p], y[p], datify)) { return false; }
Severity: Major
Found in test/helpers.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return sendError(util.format('The process seems to have ended prematurely, please see %s',
                report.general['URL-Traces']));
    Severity: Major
    Found in lib/ecmake.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return mongo.disconnect();
      Severity: Major
      Found in lib/bin/checkconfig.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return this;
        Severity: Major
        Found in lib/ecmake.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if (!req.body.jobID) { return sendMail(); }
          Severity: Major
          Found in routes/feedback.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return true;
            Severity: Major
            Found in test/helpers.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return Promise.reject(Boom.boomify(mw, { statusCode: mw.status }));
              Severity: Major
              Found in lib/job/init.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return next(Boom.badRequest('wrongPassword'));
                Severity: Major
                Found in routes/admin.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          if (!reportFile) { return callback(); }
                  Severity: Major
                  Found in lib/ecmake.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                              return reject(err);
                    Severity: Major
                    Found in routes/admin.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          if (typeof(x[p]) !== 'object') { return false; }
                      Severity: Major
                      Found in test/helpers.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return sendError('Unsupported input type');
                        Severity: Major
                        Found in lib/ecmake.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              if (y.hasOwnProperty(p) && !x.hasOwnProperty(p)) { return false; }
                          Severity: Major
                          Found in test/helpers.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                              return format;
                            Severity: Major
                            Found in lib/proxyformats/squid.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                  return next(null);
                              Severity: Major
                              Found in lib/init/init-writer.js - About 30 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language