Sign upLogin

fabiocaccamo/django-admin-interface

View on GitHub
Star

Showing 11 of 11 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

(function() {

    'use strict';

    var windowRef = window;
Severity: Major
Found in admin_interface/static/streamfield/admin_popup_response.js and 1 other location - About 6 hrs to fix
admin_interface/static/streamfield/js/admin_popup_response.js on lines 3..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

(function() {

    'use strict';

    var windowRef = window;
Severity: Major
Found in admin_interface/static/streamfield/js/admin_popup_response.js and 1 other location - About 6 hrs to fix
admin_interface/static/streamfield/admin_popup_response.js on lines 3..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File models.py has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from colorfield.fields import ColorField
from django.core.validators import FileExtensionValidator
from django.db import models
from django.db.models.signals import post_delete, post_save, pre_save
from django.dispatch import receiver
Severity: Minor
Found in admin_interface/models.py - About 5 hrs to fix

    Function presentRelatedObjectModal has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                function presentRelatedObjectModal(e) {
                const linkEl = $(this);

                const href = (linkEl.attr('href') || '');
                if (href === '') {
    Severity: Minor
    Found in admin_interface/static/admin_interface/related-modal/related-modal.js - About 1 hr to fix

      Function onload has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          window.onload = function() {
        for (let moduleEl of document.querySelectorAll('.admin-interface.foldable-apps [class^="app-"].module')) {
            // apply collapsed value from localstorage value
            let moduleAppClass = null;
            let moduleCollapsedClass = 'collapsed';
      Severity: Minor
      Found in admin_interface/static/admin_interface/foldable-apps/foldable-apps.js - About 1 hr to fix

        Function check_installed_app has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        def check_installed_app(app, max_dj_version=None):
    dj_version = django.VERSION
    installed_apps = settings.INSTALLED_APPS
    if max_dj_version is None:
        if app not in installed_apps:
        Severity: Minor
        Found in admin_interface/settings.py - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return context
        Severity: Major
        Found in admin_interface/templatetags/admin_interface_tags.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return None
          Severity: Major
          Found in admin_interface/templatetags/admin_interface_tags.py - About 30 mins to fix

            Function admin_interface_date_hierarchy_removal_link has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def admin_interface_date_hierarchy_removal_link(changelist, date_field_name):
    date_field_path = get_fields_from_path(changelist.model, date_field_name)
    # date_field = date_field_path[-1]
    date_labels = [str(field.verbose_name) for field in date_field_path]
    date_label = " ".join(date_labels).lower()
            Severity: Minor
            Found in admin_interface/templatetags/admin_interface_tags.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_active has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def get_active(self):
        objs_active_qs = self.filter(active=True)
        objs_active_ls = list(objs_active_qs)
        objs_active_count = len(objs_active_ls)
            Severity: Minor
            Found in admin_interface/models.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function admin_interface_language_chooser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def admin_interface_language_chooser(context):
    if not settings.USE_I18N:
        # i18n disabled
        return None
    if len(settings.LANGUAGES) < 2:
            Severity: Minor
            Found in admin_interface/templatetags/admin_interface_tags.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language