Sign upLogin

fabiommendes/django-bricks

View on GitHub
Star

Showing 97 of 97 total issues

Cyclomatic complexity is too high in function badge. (6)
Open

@mdl_shadow
def badge(children=None, badge=None, class_=None,
          no_background=False, overlap=False,
          href=None, tag=None, icon=None,
          **kwargs):
Severity: Minor
Found in src/bricks/contrib/mdl/components.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method require. (6)
Open

    def require(self, *assets, resolve=True):
        """
        Requires the given asset.
        """
Severity: Minor
Found in src/bricks/assets/manager.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function encode. (6)
Open

def encode(data):
    """
    Encode some arbitrary Python data into a JSON-compatible structure.

    This naive implementation does not handle recursive structures. This might
Severity: Minor
Found in src/bricks/json/encoders.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function register. (6)
Open

def register(cls, name=None, encode=None, decode=None):
    """
    Register encode/decode pair of functions for the given Python type.
    Registration extends Bricks flavored JSON to handle arbitrary python
    objects.
Severity: Minor
Found in src/bricks/json/common.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function bricks_register has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def bricks_register(view_cls, *args, name=None, register=True, **kwargs):
    """
    Worker function for api and program callbacks.
    """
Severity: Minor
Found in src/bricks/rpc/decorators.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rpc has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    bricks.rpc = function (args) {
        // Initialize parameters
        args = $.extend({
            api: undefined,
            params: {},
Severity: Minor
Found in src/bricks/app/static/js/bricks/core.js - About 1 hr to fix

    Function _getDialog has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function _getDialog(args, action) {
        args = args || {};
        var dialog = args.dialog || byId(args.dialogId || 'dialog');
        var content = args.dialogContent || byId(args.dialogContentId || 'dialog-content');
    Severity: Minor
    Found in src/bricks/app/static/js/bricks/dialog.js - About 1 hr to fix

      Function button has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def button(children=None, class_=None,
      Severity: Major
      Found in src/bricks/contrib/mdl/components.py - About 1 hr to fix

        Function getFormData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function getFormData(form) {
        var files = {};
        var pending = {__size: 0};
        var formData = {fileData: files, __pending: pending};
        var params = $(form).serializeArray();
        Severity: Minor
        Found in src/bricks/app/static/js/bricks/core.js - About 1 hr to fix

          Function badge has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def badge(children=None, badge=None, class_=None,
          Severity: Major
          Found in src/bricks/contrib/mdl/components.py - About 1 hr to fix

            Function __eq__ has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def __eq__(self, other):
        if other.__class__ is self.__class__:
            if self.classes != other.classes:
                return False
            if self.attrs != other.attrs:
            Severity: Minor
            Found in src/bricks/components/core.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function resolve_suggested has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def resolve_suggested(self):
        """
        Resolve all requirements that can be resolved by loading a suggested
        asset.
        """
            Severity: Minor
            Found in src/bricks/assets/manager.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function check_credentials has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def check_credentials(self, request):
        """
        Assure that user has the correct credentials to the process.

        Must raise a BadResponseError if credentials are not valid.
            Severity: Minor
            Found in src/bricks/rpc/views.py - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function form_row has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def form_row(label, input, errors=None, help_text=None, class_=None,
            Severity: Major
            Found in src/bricks/forms.py - About 50 mins to fix

              Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self, children=None, *, class_=None, id=None, attrs=None,
              Severity: Minor
              Found in src/bricks/components/core.py - About 45 mins to fix

                Function load has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    def load(self, asset):
        """
        Load an asset and update the requires, provides and suggests lists.
        """
                Severity: Minor
                Found in src/bricks/assets/manager.py - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def __init__(self, name, href, provides=None, rel=None, type=None,
                Severity: Minor
                Found in src/bricks/assets/assets.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if label not in reqset:
                        reqset.add(label)
                        reqlist.append(label)
                visited_requires.add(id(child.requires))
                  Severity: Major
                  Found in src/bricks/assets/utils.py - About 45 mins to fix

                    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def __init__(self, function, action='api', login_required=False,
                    Severity: Minor
                    Found in src/bricks/rpc/views.py - About 45 mins to fix

                      Function decorator has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def decorator(decorator_func):
    """
    Makes a function behave like a decorator.
    """
                      Severity: Minor
                      Found in src/bricks/rpc/decorators.py - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language