Sign upLogin

fabric8io/fluent-plugin-kubernetes_metadata_filter

View on GitHub
Star

Showing 24 of 24 total issues

Method get_metadata_for_record has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_metadata_for_record(namespace_name, pod_name, container_name, cache_key, create_time, batch_miss_cache, docker_id)
Severity: Major
Found in lib/fluent/plugin/filter_kubernetes_metadata.rb - About 50 mins to fix

    Method get_pod_metadata has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_pod_metadata(key, namespace_name, pod_name, time, batch_miss_cache)
    Severity: Minor
    Found in lib/fluent/plugin/kubernetes_metadata_cache_strategy.rb - About 35 mins to fix

      Method parse_namespace_metadata has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse_namespace_metadata(namespace_object)
      labels = ''
      labels = syms_to_strs(namespace_object[:metadata][:labels].to_h) unless (@skip_labels || @skip_namespace_labels)

      annotations = match_annotations(syms_to_strs(namespace_object[:metadata][:annotations].to_h))
      Severity: Minor
      Found in lib/fluent/plugin/kubernetes_metadata_common.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method syms_to_strs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def syms_to_strs(hsh)
      newhsh = {}
      hsh.each_pair do |kk, vv|
        if vv.is_a?(Hash)
          vv = syms_to_strs(vv)
      Severity: Minor
      Found in lib/fluent/plugin/kubernetes_metadata_common.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language