Sign upLogin

fabric8io/fluent-plugin-kubernetes_metadata_filter

View on GitHub
Star
lib/fluent/plugin/kubernetes_metadata_watch_pods.rb

Summary

Maintainability
C
1 day
Test Coverage

Method process_pod_watcher_notices has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def process_pod_watcher_notices(watcher)
      watcher.each do |notice|
        # store version we processed to not reprocess it ... do not unset when there is no version in response
        version = ( # TODO: replace with &.dig once we are on ruby 2.5+
          notice[:object] && notice[:object][:metadata] && notice[:object][:metadata][:resourceVersion]
Severity: Minor
Found in lib/fluent/plugin/kubernetes_metadata_watch_pods.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_up_pod_thread has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def set_up_pod_thread
      # Any failures / exceptions in the initial setup should raise
      # Fluent:ConfigError, so that users can inspect potential errors in
      # the configuration.
      pod_watcher = start_pod_watch
Severity: Major
Found in lib/fluent/plugin/kubernetes_metadata_watch_pods.rb - About 2 hrs to fix

    Method set_up_pod_thread has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_up_pod_thread
      # Any failures / exceptions in the initial setup should raise
      # Fluent:ConfigError, so that users can inspect potential errors in
      # the configuration.
      pod_watcher = start_pod_watch
    Severity: Minor
    Found in lib/fluent/plugin/kubernetes_metadata_watch_pods.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process_pod_watcher_notices has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def process_pod_watcher_notices(watcher)
      watcher.each do |notice|
        # store version we processed to not reprocess it ... do not unset when there is no version in response
        version = ( # TODO: replace with &.dig once we are on ruby 2.5+
          notice[:object] && notice[:object][:metadata] && notice[:object][:metadata][:resourceVersion]
    Severity: Minor
    Found in lib/fluent/plugin/kubernetes_metadata_watch_pods.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status