Sign upLogin

fadendaten/six_saferpay

View on GitHub
Star

Showing 73 of 92 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module SixSecureData
    class InsertDirect

      attr_accessor(:request_header,
                    :register_alias,
Severity: Major
Found in lib/six_saferpay/api/six_secure_card_data/requests/insert_direct.rb and 1 other location - About 2 hrs to fix
lib/six_saferpay/api/six_transaction/requests/refund.rb on lines 2..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module SixTransaction
    class Refund

      attr_accessor(:request_header,
                    :refund,
Severity: Major
Found in lib/six_saferpay/api/six_transaction/requests/refund.rb and 1 other location - About 2 hrs to fix
lib/six_saferpay/api/six_secure_card_data/requests/insert_direct.rb on lines 2..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  module SixSecureData
    class InsertDirectResponse

      attr_accessor(:response_header,
                    :fd_alias,
Severity: Major
Found in lib/six_saferpay/api/six_secure_card_data/responses/insert_direct_response.rb and 4 other locations - About 2 hrs to fix
lib/six_saferpay/api/six_omni_channel/responses/insert_alias_response.rb on lines 2..32
lib/six_saferpay/api/six_secure_card_data/responses/assert_insert_response.rb on lines 2..31
lib/six_saferpay/api/six_transaction/responses/refund_direct_response.rb on lines 2..32
lib/six_saferpay/api/six_transaction/responses/refund_response.rb on lines 2..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  module SixSecureData
    class AssertInsertResponse

      attr_accessor(:response_header,
                    :fd_alias,
Severity: Major
Found in lib/six_saferpay/api/six_secure_card_data/responses/assert_insert_response.rb and 4 other locations - About 2 hrs to fix
lib/six_saferpay/api/six_omni_channel/responses/insert_alias_response.rb on lines 2..32
lib/six_saferpay/api/six_secure_card_data/responses/insert_direct_response.rb on lines 2..31
lib/six_saferpay/api/six_transaction/responses/refund_direct_response.rb on lines 2..32
lib/six_saferpay/api/six_transaction/responses/refund_response.rb on lines 2..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  module SixOmniChannel
    class InsertAliasResponse

      attr_accessor(:response_header,
                    :fd_alias,
Severity: Major
Found in lib/six_saferpay/api/six_omni_channel/responses/insert_alias_response.rb and 4 other locations - About 2 hrs to fix
lib/six_saferpay/api/six_secure_card_data/responses/assert_insert_response.rb on lines 2..31
lib/six_saferpay/api/six_secure_card_data/responses/insert_direct_response.rb on lines 2..31
lib/six_saferpay/api/six_transaction/responses/refund_direct_response.rb on lines 2..32
lib/six_saferpay/api/six_transaction/responses/refund_response.rb on lines 2..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  module SixTransaction
    class RefundResponse

      attr_accessor(:response_header,
                    :transaction,
Severity: Major
Found in lib/six_saferpay/api/six_transaction/responses/refund_response.rb and 4 other locations - About 2 hrs to fix
lib/six_saferpay/api/six_omni_channel/responses/insert_alias_response.rb on lines 2..32
lib/six_saferpay/api/six_secure_card_data/responses/assert_insert_response.rb on lines 2..31
lib/six_saferpay/api/six_secure_card_data/responses/insert_direct_response.rb on lines 2..31
lib/six_saferpay/api/six_transaction/responses/refund_direct_response.rb on lines 2..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  module SixTransaction
    class RefundDirectResponse

      attr_accessor(:response_header,
                    :transaction,
Severity: Major
Found in lib/six_saferpay/api/six_transaction/responses/refund_direct_response.rb and 4 other locations - About 2 hrs to fix
lib/six_saferpay/api/six_omni_channel/responses/insert_alias_response.rb on lines 2..32
lib/six_saferpay/api/six_secure_card_data/responses/assert_insert_response.rb on lines 2..31
lib/six_saferpay/api/six_secure_card_data/responses/insert_direct_response.rb on lines 2..31
lib/six_saferpay/api/six_transaction/responses/refund_response.rb on lines 2..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module SixTransaction
    class AssertRefundResponse

      attr_accessor(:response_header,
                    :transaction_id,
Severity: Major
Found in lib/six_saferpay/api/six_transaction/responses/assert_refund_response.rb and 1 other location - About 2 hrs to fix
lib/six_saferpay/api/six_transaction/responses/assert_capture_response.rb on lines 2..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  module SixTransaction
    class AssertCaptureResponse

      attr_accessor(:response_header,
                    :transaction_id,
Severity: Major
Found in lib/six_saferpay/api/six_transaction/responses/assert_capture_response.rb and 1 other location - About 2 hrs to fix
lib/six_saferpay/api/six_transaction/responses/assert_refund_response.rb on lines 2..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      def to_hash
        hash = Hash.new
        hash.merge!(response_header: @response_header.to_h) if @response_header
        hash.merge!(transaction: @transaction.to_h) if @transaction
        hash.merge!(payment_means: @payment_means.to_h) if @payment_means
Severity: Major
Found in lib/six_saferpay/api/six_transaction/responses/authorize_response.rb and 1 other location - About 2 hrs to fix
lib/six_saferpay/api/six_payment_page/responses/assert_response.rb on lines 40..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      def to_hash
        hash = Hash.new
        hash.merge!(response_header: @response_header.to_h) if @response_header
        hash.merge!(transaction: @transaction.to_h) if @transaction
        hash.merge!(payment_means: @payment_means.to_h) if @payment_means
Severity: Major
Found in lib/six_saferpay/api/six_payment_page/responses/assert_response.rb and 1 other location - About 2 hrs to fix
lib/six_saferpay/api/six_transaction/responses/authorize_response.rb on lines 41..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 78.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method to_hash has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def to_hash
      hash = Hash.new
      if !@has_account.nil?
        hash.merge!(has_account: @has_account)
      end
Severity: Minor
Found in lib/six_saferpay/models/payer_profile.rb - About 1 hr to fix

    Method to_hash has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_hash
      hash = Hash.new
      if !@has_account.nil?
        hash.merge!(has_account: @has_account)
      end
    Severity: Minor
    Found in lib/six_saferpay/models/payer_profile.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      module SixTransaction
    class Inquire

      attr_accessor(:request_header,
                    :transaction_reference)
    Severity: Major
    Found in lib/six_saferpay/api/six_transaction/requests/inquire.rb and 4 other locations - About 1 hr to fix
    lib/six_saferpay/api/six_transaction/requests/assert_capture.rb on lines 2..34
    lib/six_saferpay/api/six_transaction/requests/assert_refund.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/cancel.rb on lines 2..32
    lib/six_saferpay/api/six_transaction/requests/multipart_finalize.rb on lines 2..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      module SixTransaction
    class Cancel

      attr_accessor :request_header,
                    :transaction_reference
    Severity: Major
    Found in lib/six_saferpay/api/six_transaction/requests/cancel.rb and 4 other locations - About 1 hr to fix
    lib/six_saferpay/api/six_transaction/requests/assert_capture.rb on lines 2..34
    lib/six_saferpay/api/six_transaction/requests/assert_refund.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/inquire.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/multipart_finalize.rb on lines 2..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      module SixTransaction
    class AssertRefund

      attr_accessor(:request_header,
                    :transaction_reference)
    Severity: Major
    Found in lib/six_saferpay/api/six_transaction/requests/assert_refund.rb and 4 other locations - About 1 hr to fix
    lib/six_saferpay/api/six_transaction/requests/assert_capture.rb on lines 2..34
    lib/six_saferpay/api/six_transaction/requests/cancel.rb on lines 2..32
    lib/six_saferpay/api/six_transaction/requests/inquire.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/multipart_finalize.rb on lines 2..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      module SixTransaction
    class MultipartFinalize

      attr_accessor(:request_header,
                    :transaction_reference
    Severity: Major
    Found in lib/six_saferpay/api/six_transaction/requests/multipart_finalize.rb and 4 other locations - About 1 hr to fix
    lib/six_saferpay/api/six_transaction/requests/assert_capture.rb on lines 2..34
    lib/six_saferpay/api/six_transaction/requests/assert_refund.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/cancel.rb on lines 2..32
    lib/six_saferpay/api/six_transaction/requests/inquire.rb on lines 2..33

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      module SixTransaction
    class AssertCapture

      attr_accessor(:request_header,
                    :capture_reference
    Severity: Major
    Found in lib/six_saferpay/api/six_transaction/requests/assert_capture.rb and 4 other locations - About 1 hr to fix
    lib/six_saferpay/api/six_transaction/requests/assert_refund.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/cancel.rb on lines 2..32
    lib/six_saferpay/api/six_transaction/requests/inquire.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/multipart_finalize.rb on lines 2..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method to_hash has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_hash
      hash = Hash.new
      hash.merge!(type: @type) if @type
      hash.merge!(id: @id) if @id
      hash.merge!(variant_id: @variant_id) if @variant_id
    Severity: Minor
    Found in lib/six_saferpay/models/item.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      module SixSecureData
    class AssertInsert

      attr_accessor(:request_header,
                    :token
    Severity: Major
    Found in lib/six_saferpay/api/six_secure_card_data/requests/assert_insert.rb and 3 other locations - About 1 hr to fix
    lib/six_saferpay/api/six_batch/requests/close.rb on lines 2..33
    lib/six_saferpay/api/six_secure_card_data/requests/delete.rb on lines 2..33
    lib/six_saferpay/api/six_transaction/requests/query_alternative_payment.rb on lines 2..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language