Sign upLogin

fairmondo/fairmondo

View on GitHub
Star
app/validators/common_sense_validator.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method validate_each has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def validate_each(record, attribute, selected_payment)
    if record.is_a? BusinessTransaction
      common_sense_error = common_sense_check selected_payment, record.selected_transport
      record.errors[attribute] << common_sense_error if common_sense_error
Severity: Minor
Found in app/validators/common_sense_validator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method common_sense_check has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def common_sense_check selected_payment, selected_transport
    if (selected_payment == 'cash_on_delivery' && selected_transport == 'pickup') || (selected_payment == 'cash' && selected_transport != 'pickup')
      I18n.t 'transaction.errors.combination_invalid',
             selected_payment: I18n.t("enumerize.business_transaction.selected_payment.#{selected_payment}")
    elsif (selected_payment != 'paypal' && selected_transport == 'bike_courier')
Severity: Minor
Found in app/validators/common_sense_validator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status