Sign upLogin

fairplaysk/datacamp

View on GitHub
Star
app/models/parsers/donations_parser/parser.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method parse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def self.parse(html, year)
        ::Parsers::Support.save(parse_location(year), 'csv', bucketize: false)
        CSV.open(::Parsers::Support.get_path(parse_location(year), bucketize: false), "wb", force_quotes: true) do |csv|
          csv << ATTRIBUTES
Severity: Minor
Found in app/models/parsers/donations_parser/parser.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.parse(html, year)
        ::Parsers::Support.save(parse_location(year), 'csv', bucketize: false)
        CSV.open(::Parsers::Support.get_path(parse_location(year), bucketize: false), "wb", force_quotes: true) do |csv|
          csv << ATTRIBUTES
Severity: Minor
Found in app/models/parsers/donations_parser/parser.rb - About 1 hr to fix

    Method parse_recipient_2013 has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def self.parse_recipient_2013(td)
          proposal = {}
          e = td.css('span.cervene').first
          return proposal unless e
          proposal[:name] = clean_string(e.text)
    Severity: Minor
    Found in app/models/parsers/donations_parser/parser.rb - About 1 hr to fix

      Method parse_recipient_2007_2012 has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def self.parse_recipient_2007_2012(td)
          proposal = {}
          e = td.css('span.cervene').first
          return proposal unless e
          proposal[:name] = clean_string(e.text)
      Severity: Minor
      Found in app/models/parsers/donations_parser/parser.rb - About 1 hr to fix

        Method parse_recipient_2007_2012 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def self.parse_recipient_2007_2012(td)
          proposal = {}
          e = td.css('span.cervene').first
          return proposal unless e
          proposal[:name] = clean_string(e.text)
        Severity: Minor
        Found in app/models/parsers/donations_parser/parser.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status