Sign upLogin

fairplaysk/datacamp

View on GitHub
Star
lib/etl/vvo_v2/customer_information_parser.rb

Summary

Maintainability
F
3 days
Test Coverage

Method customer_information has a Cognitive Complexity of 105 (exceeds 5 allowed). Consider refactoring.
Open

      def customer_information
        customer_information_hash = {}

        case document_format
          when :format1
Severity: Minor
Found in lib/etl/vvo_v2/customer_information_parser.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method customer_information has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def customer_information
        customer_information_hash = {}

        case document_format
          when :format1
Severity: Major
Found in lib/etl/vvo_v2/customer_information_parser.rb - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                          while next_tr && next_tr.xpath(".//td[@class='kod']").inner_text.blank?
                        activities << next_tr.inner_text.strip if next_tr.inner_text.strip.present?
                        next_tr = next_tr.next_sibling
                      end
    Severity: Major
    Found in lib/etl/vvo_v2/customer_information_parser.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                        elsif header1.match(/Verejný obstarávateľ nakupuje/) || header2.match(/Verejný obstarávateľ nakupuje/)
                    customer_information_hash[:customer_purchase_for_others] = !content.match(/Nie/)
      Severity: Major
      Found in lib/etl/vvo_v2/customer_information_parser.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            while next_tr && (next_tr.inner_text.strip.match(/Verejný obstarávateľ nakupuje/).nil? && next_tr.xpath(".//td[@class='kod']").inner_text.blank?)
                      content = next_tr.inner_text.strip
                      activities << content if content.present?
                      next_tr = next_tr.next_sibling
                    end
        Severity: Major
        Found in lib/etl/vvo_v2/customer_information_parser.rb - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                            elsif span.inner_text.strip.start_with?('Telefón')
                    customer_information_hash[:customer_phone] = span.next_sibling.next_sibling.inner_text.strip
                  elsif span.inner_text.strip.start_with?('Fax')
                    customer_information_hash[:customer_fax] = span.next_sibling.next_sibling.inner_text.strip
                  elsif span.inner_text.strip.start_with?('Email')
          Severity: Major
          Found in lib/etl/vvo_v2/customer_information_parser.rb and 1 other location - About 1 hr to fix
          lib/etl/vvo_v2/suppliers_information_parser.rb on lines 93..101

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 56.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                            elsif header.match(/Telefón/)
                    customer_information_hash[:customer_phone] = content
                  elsif header.match(/Fax/)
                    customer_information_hash[:customer_fax] = content
                  elsif header.match(/E-mail/)
          Severity: Minor
          Found in lib/etl/vvo_v2/customer_information_parser.rb and 1 other location - About 30 mins to fix
          lib/etl/vvo_v2/suppliers_information_parser.rb on lines 233..241

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status