Sign upLogin

faloker/purify

View on GitHub
Star
api/src/templates/templates.service.ts

Summary

Maintainability
A
1 hr
Test Coverage
D
64%

Avoid deeply nested control flow statements.
Wontfix

            if (originalField) {
              if (
                typeof originalField === 'string' &&
                !originalField.toLowerCase().includes(newField.toLowerCase())
              ) {
Severity: Major
Found in api/src/templates/templates.service.ts - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (oldTemplate) {
      await this.templateModel.updateOne({ name }, template);
      return this.templateModel.findOne({ name }).lean();
    } else {
    Severity: Major
    Found in api/src/templates/templates.service.ts and 1 other location - About 1 hr to fix
    api/src/projects/projects.service.ts on lines 70..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

              allTemplateIssuesInUnit = allTemplateIssuesInUnit.map((issue) =>
            issue._id === issueToUpdate._id
              ? { ...issue, fields: JSON.stringify(oldIssueFields) }
              : issue
          );
    Severity: Minor
    Found in api/src/templates/templates.service.ts and 1 other location - About 55 mins to fix
    api/src/templates/templates.service.ts on lines 143..147

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Wontfix

              allIssuesInUnit = allIssuesInUnit.map((issue) =>
            issue._id === issueToUpdate._id
              ? { ...issue, fields: JSON.stringify(oldIssueFields) }
              : issue
          );
    Severity: Minor
    Found in api/src/templates/templates.service.ts and 1 other location - About 55 mins to fix
    api/src/templates/templates.service.ts on lines 137..141

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        let allTemplateIssuesInUnit = await this.issueModel
      .find({
        unit: report.unit,
        template: template._id,
      })
    Severity: Minor
    Found in api/src/templates/templates.service.ts and 1 other location - About 35 mins to fix
    api/src/users/users.service.ts on lines 212..217

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status