Sign upLogin

fastladder/fastladder

View on GitHub
Star
app/models/member.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Member has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class Member < ActiveRecord::Base
  # Virtual attribute for the unencrypted password
  attr_accessor :password
  serialize :config_dump
Severity: Minor
Found in app/models/member.rb - About 2 hrs to fix

    Method export has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def export(format)
    case format
    when 'opml'
      folders = {}
      subs = subscriptions.includes(:folder).order("subscriptions.id")
    Severity: Minor
    Found in app/models/member.rb - About 1 hr to fix

      Method export has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def export(format)
    case format
    when 'opml'
      folders = {}
      subs = subscriptions.includes(:folder).order("subscriptions.id")
      Severity: Minor
      Found in app/models/member.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method subscribe_feed has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def subscribe_feed(feedlink, options = {})
    if self.subscriptions.size >= Settings.subscribe_limit
      logger.warn "SUBSCRIBE LIMIT: #{self.username}(#{self.id}) #{feedlink}"
      return nil
    end
      Severity: Minor
      Found in app/models/member.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status