Sign upLogin

fastlane/ci

View on GitHub
Star
app/shared/models/git_repo.rb

Summary

Maintainability
F
4 days
Test Coverage

File git_repo.rb has 551 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "git"
require "tty-command"
require "securerandom"
require "digest"
require "task_queue"
Severity: Major
Found in app/shared/models/git_repo.rb - About 1 day to fix

    Method setup_repo has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
    Open

        def setup_repo
      retry_count ||= 0
      if File.directory?(local_folder)
        # TODO: test if this crashes if it's not a git directory
        begin
    Severity: Minor
    Found in app/shared/models/git_repo.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class GitRepo has 31 methods (exceeds 20 allowed). Consider refactoring.
    Open

      class GitRepo
    # rubocop:enable Metrics/ClassLength
    include FastlaneCI::Logging

    DEFAULT_REMOTE = "origin"
    Severity: Minor
    Found in app/shared/models/git_repo.rb - About 3 hrs to fix

      Method setup_repo has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def setup_repo
      retry_count ||= 0
      if File.directory?(local_folder)
        # TODO: test if this crashes if it's not a git directory
        begin
      Severity: Major
      Found in app/shared/models/git_repo.rb - About 2 hrs to fix

        Method handle_exception has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def handle_exception(ex, console_message: nil, exception_context: {})
      unless console_message.nil?
        logger.error(console_message)
      end
      logger.error(ex)
        Severity: Major
        Found in app/shared/models/git_repo.rb - About 2 hrs to fix

          Method commit_changes! has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              def commit_changes!(commit_message: nil, push_after_commit: true, files_to_commit: [], repo_auth: self.repo_auth)
      git_action_with_queue do
        logger.debug("Starting commit_changes! #{git_config.git_url} for #{repo_auth.username}")
        commit_message ||= "Automatic commit by fastlane.ci"
          Severity: Minor
          Found in app/shared/models/git_repo.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def initialize(
      git_config: nil,
      local_folder: nil,
      provider_credential: nil,
      async_start: false,
          Severity: Minor
          Found in app/shared/models/git_repo.rb - About 1 hr to fix

            Method handle_exception has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                def handle_exception(ex, console_message: nil, exception_context: {})
      unless console_message.nil?
        logger.error(console_message)
      end
      logger.error(ex)
            Severity: Minor
            Found in app/shared/models/git_repo.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method commit_changes! has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def commit_changes!(commit_message: nil, push_after_commit: true, files_to_commit: [], repo_auth: self.repo_auth)
      git_action_with_queue do
        logger.debug("Starting commit_changes! #{git_config.git_url} for #{repo_auth.username}")
        commit_message ||= "Automatic commit by fastlane.ci"
            Severity: Minor
            Found in app/shared/models/git_repo.rb - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                            rescue StandardError => ex
                handle_exception(ex, console_message: "Error commiting changes to ci-config repo")
              Severity: Major
              Found in app/shared/models/git_repo.rb - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                              if repo.status.changed.count > 0 ||
                 repo.status.added.count > 0 ||
                 repo.status.deleted.count > 0 ||
                 repo.status.untracked.count > 0
                begin
                Severity: Major
                Found in app/shared/models/git_repo.rb - About 45 mins to fix

                  Method checkout_commit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def checkout_commit(sha: nil, repo_auth: self.repo_auth, use_global_git_mutex: true, completion_block: nil)
      perform_block(use_global_git_mutex: use_global_git_mutex) do
        repo_url = git_config.git_url
        logger.info("Checking out sha: #{sha} from #{repo_url}")
        setup_auth(repo_auth: repo_auth)
                  Severity: Minor
                  Found in app/shared/models/git_repo.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method validate_initialization_params! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def validate_initialization_params!(
      git_config: nil,
      local_folder: nil,
      provider_credential: nil,
      async_start: nil,
                  Severity: Minor
                  Found in app/shared/models/git_repo.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                        def pushes_disabled?
        push_state = ENV["FASTLANE_CI_DISABLE_PUSHES"]
        return false if push_state.nil?

        push_state = push_state.to_s
                  Severity: Minor
                  Found in app/shared/models/git_repo.rb and 1 other location - About 15 mins to fix
                  app/services/code_hosting/git_hub_service.rb on lines 21..28

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 26.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          priority = Notification::PRIORITIES[:urgent]
        notification_service.create_notification!(
          priority: priority,
          name: "Unable to checkout object",
          message: "Unable to checkout an object (probably a branch) from #{git_config.git_url}",
                  Severity: Minor
                  Found in app/shared/models/git_repo.rb and 2 other locations - About 15 mins to fix
                  app/shared/models/git_repo.rb on lines 223..229
                  app/shared/models/git_repo.rb on lines 235..241

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 25.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          priority = Notification::PRIORITIES[:urgent]
        notification_service.create_notification!(
          priority: priority,
          name: "Unable to check out sha",
          message: "Unable to checkout an object from #{git_config.git_url}",
                  Severity: Minor
                  Found in app/shared/models/git_repo.rb and 2 other locations - About 15 mins to fix
                  app/shared/models/git_repo.rb on lines 223..229
                  app/shared/models/git_repo.rb on lines 244..250

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 25.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 3 locations. Consider refactoring.
                  Open

                          priority = Notification::PRIORITIES[:urgent]
        notification_service.create_notification!(
          priority: priority,
          name: "Repo syncing error: merge conflict",
          message: "Unable to build #{git_config.git_url}",
                  Severity: Minor
                  Found in app/shared/models/git_repo.rb and 2 other locations - About 15 mins to fix
                  app/shared/models/git_repo.rb on lines 235..241
                  app/shared/models/git_repo.rb on lines 244..250

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 25.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status