Sign upLogin

fbi-cde/crime-data-api

View on GitHub
Star
crime_data/resources/nibrs_counts.py

Summary

Maintainability
D
2 days
Test Coverage

Cyclomatic complexity is too high in class NIBRSCountState. (27)
Open

class NIBRSCountState(CdeResource):
    @use_args(ArgumentsSchema)
    @cache(max_age=DEFAULT_MAX_AGE, public=True)
    def get(self, args, variable,queryType,state_abbr=None, offense_name=None):
        self.verify_api_key(args)
Severity: Minor
Found in crime_data/resources/nibrs_counts.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method get. (27)
Open

    @use_args(ArgumentsSchema)
    @cache(max_age=DEFAULT_MAX_AGE, public=True)
    def get(self, args, variable,queryType, offense_name=None):
        self.verify_api_key(args)
        if queryType == 'victim' and variable == 'count':
Severity: Minor
Found in crime_data/resources/nibrs_counts.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in class NIBRSCountNational. (27)
Open

class NIBRSCountNational(CdeResource):
    @use_args(ArgumentsSchema)
    @cache(max_age=DEFAULT_MAX_AGE, public=True)
    def get(self, args, variable,queryType, offense_name=None):
        self.verify_api_key(args)
Severity: Minor
Found in crime_data/resources/nibrs_counts.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in class NIBRSCountAgency. (27)
Open

class NIBRSCountAgency(CdeResource):
    @use_args(ArgumentsSchema)
    @cache(max_age=DEFAULT_MAX_AGE, public=True)
    def get(self, args, variable,queryType,ori=None, offense_name=None):
        self.verify_api_key(args)
Severity: Minor
Found in crime_data/resources/nibrs_counts.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method get. (27)
Open

    @use_args(ArgumentsSchema)
    @cache(max_age=DEFAULT_MAX_AGE, public=True)
    def get(self, args, variable,queryType,state_abbr=None, offense_name=None):
        self.verify_api_key(args)
        if queryType == 'victim' and variable == 'count':
Severity: Minor
Found in crime_data/resources/nibrs_counts.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method get. (27)
Open

    @use_args(ArgumentsSchema)
    @cache(max_age=DEFAULT_MAX_AGE, public=True)
    def get(self, args, variable,queryType,ori=None, offense_name=None):
        self.verify_api_key(args)
        if queryType == 'victim' and variable == 'count':
Severity: Minor
Found in crime_data/resources/nibrs_counts.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Consider simplifying this complex logical expression.
Open

        if queryType == 'victim' and variable == 'count':
            self.set_schema(marshmallow_schemas.NIBRSNationalVictimDenormCountSchema(many=True))
            query = cdemodels.NIBRSNationalVictimDenormCount.get(offense_name=get_offenses(offense_name))
            creator = munger.UIComponentCreator(query.all(),'nibrs_count_victim','')
        elif queryType == 'victim' and variable == 'sex':
Severity: Critical
Found in crime_data/resources/nibrs_counts.py - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if queryType == 'victim' and variable == 'count':
            self.set_schema(marshmallow_schemas.NIBRSAgencyVictimDenormCountSchema(many=True))
            query = cdemodels.NIBRSAgencyVictimDenormCount.get(ori=ori,offense_name=get_offenses(offense_name))
        elif queryType == 'victim' and variable == 'sex':
            self.set_schema(marshmallow_schemas.NIBRSAgencyVictimDenormSexSchema(many=True))
    Severity: Critical
    Found in crime_data/resources/nibrs_counts.py - About 3 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if queryType == 'victim' and variable == 'count':
            self.set_schema(marshmallow_schemas.NIBRSStateVictimDenormCountSchema(many=True))
            query = cdemodels.NIBRSStateVictimDenormCount.get(state_abbr=state_abbr,offense_name=get_offenses(offense_name))
        elif queryType == 'victim' and variable == 'sex':
            self.set_schema(marshmallow_schemas.NIBRSStateVictimDenormSexSchema(many=True))
      Severity: Critical
      Found in crime_data/resources/nibrs_counts.py - About 3 hrs to fix

        Cyclomatic complexity is too high in function get_offenses. (9)
        Open

        def get_offenses(offense):
    if offense == 'aggravated-assault':
        return ['Aggravated Assault']
    elif offense == 'burglary':
     return ['Burglary/Breaking & Entering']
        Severity: Minor
        Found in crime_data/resources/nibrs_counts.py by radon

        Cyclomatic Complexity

        Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

        Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

        Construct Effect on CC Reasoning
        if +1 An if statement is a single decision.
        elif +1 The elif statement adds another decision.
        else +0 The else statement does not cause a new decision. The decision is at the if.
        for +1 There is a decision at the start of the loop.
        while +1 There is a decision at the while statement.
        except +1 Each except branch adds a new conditional path of execution.
        finally +0 The finally block is unconditionally executed.
        with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
        assert +1 The assert statement internally roughly equals a conditional statement.
        Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
        Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

        Source: http://radon.readthedocs.org/en/latest/intro.html

        Function get has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            def get(self, args, variable,queryType, offense_name=None):
        self.verify_api_key(args)
        if queryType == 'victim' and variable == 'count':
            self.set_schema(marshmallow_schemas.NIBRSNationalVictimDenormCountSchema(many=True))
            query = cdemodels.NIBRSNationalVictimDenormCount.get(offense_name=get_offenses(offense_name))
        Severity: Minor
        Found in crime_data/resources/nibrs_counts.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def get(self, args, variable,queryType,state_abbr=None, offense_name=None):
        self.verify_api_key(args)
        if queryType == 'victim' and variable == 'count':
            self.set_schema(marshmallow_schemas.NIBRSStateVictimDenormCountSchema(many=True))
            query = cdemodels.NIBRSStateVictimDenormCount.get(state_abbr=state_abbr,offense_name=get_offenses(offense_name))
        Severity: Minor
        Found in crime_data/resources/nibrs_counts.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def get(self, args, variable,queryType,ori=None, offense_name=None):
        self.verify_api_key(args)
        if queryType == 'victim' and variable == 'count':
            self.set_schema(marshmallow_schemas.NIBRSAgencyVictimDenormCountSchema(many=True))
            query = cdemodels.NIBRSAgencyVictimDenormCount.get(ori=ori,offense_name=get_offenses(offense_name))
        Severity: Minor
        Found in crime_data/resources/nibrs_counts.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get_offenses has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def get_offenses(offense):
    if offense == 'aggravated-assault':
        return ['Aggravated Assault']
    elif offense == 'burglary':
     return ['Burglary/Breaking & Entering']
        Severity: Minor
        Found in crime_data/resources/nibrs_counts.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def get(self, args, variable,queryType,ori=None, offense_name=None):
        Severity: Minor
        Found in crime_data/resources/nibrs_counts.py - About 35 mins to fix

          Function get has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def get(self, args, variable,queryType,state_abbr=None, offense_name=None):
          Severity: Minor
          Found in crime_data/resources/nibrs_counts.py - About 35 mins to fix

            Avoid too many return statements within this function.
            Open

                  return ['Arson']
            Severity: Major
            Found in crime_data/resources/nibrs_counts.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return ['Murder and Nonnegligent Manslaughter']
              Severity: Major
              Found in crime_data/resources/nibrs_counts.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return
                Severity: Major
                Found in crime_data/resources/nibrs_counts.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return ['Robbery']
                  Severity: Major
                  Found in crime_data/resources/nibrs_counts.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return ['Rape', 'Sexual Assault With An Object', 'Sodomy']
                    Severity: Major
                    Found in crime_data/resources/nibrs_counts.py - About 30 mins to fix

                      There are no issues that match your filters.

                      Category
                      Status