Sign upLogin

fbredius/storybook

View on GitHub
Star
addons/controls/src/ControlsPanel.tsx

Summary

Maintainability
A
1 hr
Test Coverage

Function ControlsPanel has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const ControlsPanel: FC = () => {
  const [args, updateArgs, resetArgs] = useArgs();
  const rows = useArgTypes();
  const isArgsStory = useParameter<boolean>('__isArgsStory', false);
  const {
Severity: Minor
Found in addons/controls/src/ControlsPanel.tsx - About 1 hr to fix

    Type assertion on object literals is forbidden, use a type annotation instead.
    Open

      }, {} as ArgTypes);
    Severity: Minor
    Found in addons/controls/src/ControlsPanel.tsx by tslint

    Rule: no-object-literal-type-assertion

    Forbids an object literal to appear in a type assertion expression. Casting to any or to unknown is still allowed.

    Rationale

    Always prefer const x: T = { ... }; to const x = { ... } as T;. The type assertion in the latter case is either unnecessary or hides an error. The compiler will warn for excess properties with this syntax, but not missing required fields. For example: const x: { foo: number } = {} will fail to compile, but const x = {} as { foo: number } will succeed. Additionally, the const assertion const x = { foo: 1 } as const, introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.

    Notes
    • TypeScript Only

    Config

    One option may be configured:

    • allow-arguments allows type assertions to be used on object literals inside call expressions.
    Examples
    "no-object-literal-type-assertion": true
    "no-object-literal-type-assertion": true,[object Object]
    Schema
    {
  "type": "object",
  "properties": {
    "allow-arguments": {
      "type": "boolean"
    }
  },
  "additionalProperties": false
}

    For more information see this page.

    Use a conditional expression instead of assigning to 'acc[key]' in multiple places.
    Open

        if (arg?.control?.type !== 'color' || arg?.control?.presetColors) acc[key] = arg;
    Severity: Minor
    Found in addons/controls/src/ControlsPanel.tsx by tslint

    Rule: prefer-conditional-expression

    Recommends to use a conditional expression instead of assigning to the same thing in each branch of an if statement.

    Rationale

    This reduces duplication and can eliminate an unnecessary variable declaration.

    Config

    If check-else-if is specified, the rule also checks nested if-else-if statements.

    Examples
    "prefer-conditional-expression": true
    "prefer-conditional-expression": true,check-else-if
    Schema
    {
  "type": "string",
  "enum": [
    "check-else-if"
  ]
}

    For more information see this page.

    There are no issues that match your filters.

    Category
    Status