Similar blocks of code found in 2 locations. Consider refactoring. Open
const outputBabelconfig = await preset.babel(babelConfig, {
presets: {
// @ts-ignore
apply: async () =>
({
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
const outputWebpackconfig = await preset.webpackFinal(webpackConfig, {
presets: {
// @ts-ignore
apply: async () =>
({
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 52.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Missing semicolon Open
import type { TypescriptConfig } from '@storybook/core-common';
- Read upRead up
- Exclude checks
Rule: semicolon
Enforces consistent semicolon usage at the end of every statement.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
"always"
enforces semicolons at the end of every statement. -
"never"
disallows semicolons at the end of every statement except for when they are necessary.
The following arguments may be optionally provided:
-
"ignore-interfaces"
skips checking semicolons at the end of interface members. -
"ignore-bound-class-methods"
skips checking semicolons at the end of bound class methods. -
"strict-bound-class-methods"
disables any special handling of bound class methods and treats them as any other assignment. This option overrides"ignore-bound-class-methods"
.
Examples
"semicolon": true,always
"semicolon": true,never
"semicolon": true,always,ignore-interfaces
"semicolon": true,always,ignore-bound-class-methods
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"always",
"never"
]
},
{
"type": "string",
"enum": [
"ignore-interfaces"
]
}
],
"additionalItems": false
}
For more information see this page.
Type assertion on object literals is forbidden, use a type annotation instead. Open
({
check: false,
reactDocgen: 'react-docgen',
} as TypescriptConfig),
- Read upRead up
- Exclude checks
Rule: no-object-literal-type-assertion
Forbids an object literal to appear in a type assertion expression.
Casting to any
or to unknown
is still allowed.
Rationale
Always prefer const x: T = { ... };
to const x = { ... } as T;
.
The type assertion in the latter case is either unnecessary or hides an error.
The compiler will warn for excess properties with this syntax, but not missing required fields.
For example: const x: { foo: number } = {}
will fail to compile, but
const x = {} as { foo: number }
will succeed.
Additionally, the const assertion const x = { foo: 1 } as const
,
introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.
Notes
- TypeScript Only
Config
One option may be configured:
-
allow-arguments
allows type assertions to be used on object literals inside call expressions.
Examples
"no-object-literal-type-assertion": true
"no-object-literal-type-assertion": true,[object Object]
Schema
{
"type": "object",
"properties": {
"allow-arguments": {
"type": "boolean"
}
},
"additionalProperties": false
}
For more information see this page.
unused expression, expected an assignment or function call Open
import type { TypescriptConfig } from '@storybook/core-common';
- Read upRead up
- Exclude checks
Rule: no-unused-expression
Disallows unused expression statements.
Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).
Rationale
Detects potential errors where an assignment or function call was intended.
Config
Three arguments may be optionally provided:
-
allow-fast-null-checks
allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g.e && e.preventDefault()
). -
allow-new
allows 'new' expressions for side effects (e.g.new ModifyGlobalState();
. -
allow-tagged-template
allows tagged templates for side effects (e.g.this.add\
foo`;`.
Examples
"no-unused-expression": true
"no-unused-expression": true,allow-fast-null-checks
Schema
{
"type": "array",
"items": {
"type": "string",
"enum": [
"allow-fast-null-checks",
"allow-new",
"allow-tagged-template"
]
},
"minLength": 0,
"maxLength": 3
}
For more information see this page.
Missing semicolon Open
import type { TypescriptConfig } from '@storybook/core-common';
- Read upRead up
- Exclude checks
Rule: semicolon
Enforces consistent semicolon usage at the end of every statement.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
"always"
enforces semicolons at the end of every statement. -
"never"
disallows semicolons at the end of every statement except for when they are necessary.
The following arguments may be optionally provided:
-
"ignore-interfaces"
skips checking semicolons at the end of interface members. -
"ignore-bound-class-methods"
skips checking semicolons at the end of bound class methods. -
"strict-bound-class-methods"
disables any special handling of bound class methods and treats them as any other assignment. This option overrides"ignore-bound-class-methods"
.
Examples
"semicolon": true,always
"semicolon": true,never
"semicolon": true,always,ignore-interfaces
"semicolon": true,always,ignore-bound-class-methods
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"always",
"never"
]
},
{
"type": "string",
"enum": [
"ignore-interfaces"
]
}
],
"additionalItems": false
}
For more information see this page.
Type assertion on object literals is forbidden, use a type annotation instead. Open
({
check: false,
reactDocgen: false,
} as TypescriptConfig),
- Read upRead up
- Exclude checks
Rule: no-object-literal-type-assertion
Forbids an object literal to appear in a type assertion expression.
Casting to any
or to unknown
is still allowed.
Rationale
Always prefer const x: T = { ... };
to const x = { ... } as T;
.
The type assertion in the latter case is either unnecessary or hides an error.
The compiler will warn for excess properties with this syntax, but not missing required fields.
For example: const x: { foo: number } = {}
will fail to compile, but
const x = {} as { foo: number }
will succeed.
Additionally, the const assertion const x = { foo: 1 } as const
,
introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.
Notes
- TypeScript Only
Config
One option may be configured:
-
allow-arguments
allows type assertions to be used on object literals inside call expressions.
Examples
"no-object-literal-type-assertion": true
"no-object-literal-type-assertion": true,[object Object]
Schema
{
"type": "object",
"properties": {
"allow-arguments": {
"type": "boolean"
}
},
"additionalProperties": false
}
For more information see this page.
unused expression, expected an assignment or function call Open
import type { TypescriptConfig } from '@storybook/core-common';
- Read upRead up
- Exclude checks
Rule: no-unused-expression
Disallows unused expression statements.
Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).
Rationale
Detects potential errors where an assignment or function call was intended.
Config
Three arguments may be optionally provided:
-
allow-fast-null-checks
allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g.e && e.preventDefault()
). -
allow-new
allows 'new' expressions for side effects (e.g.new ModifyGlobalState();
. -
allow-tagged-template
allows tagged templates for side effects (e.g.this.add\
foo`;`.
Examples
"no-unused-expression": true
"no-unused-expression": true,allow-fast-null-checks
Schema
{
"type": "array",
"items": {
"type": "string",
"enum": [
"allow-fast-null-checks",
"allow-new",
"allow-tagged-template"
]
},
"minLength": 0,
"maxLength": 3
}
For more information see this page.
Type assertion on object literals is forbidden, use a type annotation instead. Open
({
check: false,
reactDocgen: false,
} as TypescriptConfig),
- Read upRead up
- Exclude checks
Rule: no-object-literal-type-assertion
Forbids an object literal to appear in a type assertion expression.
Casting to any
or to unknown
is still allowed.
Rationale
Always prefer const x: T = { ... };
to const x = { ... } as T;
.
The type assertion in the latter case is either unnecessary or hides an error.
The compiler will warn for excess properties with this syntax, but not missing required fields.
For example: const x: { foo: number } = {}
will fail to compile, but
const x = {} as { foo: number }
will succeed.
Additionally, the const assertion const x = { foo: 1 } as const
,
introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.
Notes
- TypeScript Only
Config
One option may be configured:
-
allow-arguments
allows type assertions to be used on object literals inside call expressions.
Examples
"no-object-literal-type-assertion": true
"no-object-literal-type-assertion": true,[object Object]
Schema
{
"type": "object",
"properties": {
"allow-arguments": {
"type": "boolean"
}
},
"additionalProperties": false
}
For more information see this page.
Missing semicolon Open
import type { TypescriptConfig } from '@storybook/core-common';
- Read upRead up
- Exclude checks
Rule: semicolon
Enforces consistent semicolon usage at the end of every statement.
Notes
- Has Fix
Config
One of the following arguments must be provided:
-
"always"
enforces semicolons at the end of every statement. -
"never"
disallows semicolons at the end of every statement except for when they are necessary.
The following arguments may be optionally provided:
-
"ignore-interfaces"
skips checking semicolons at the end of interface members. -
"ignore-bound-class-methods"
skips checking semicolons at the end of bound class methods. -
"strict-bound-class-methods"
disables any special handling of bound class methods and treats them as any other assignment. This option overrides"ignore-bound-class-methods"
.
Examples
"semicolon": true,always
"semicolon": true,never
"semicolon": true,always,ignore-interfaces
"semicolon": true,always,ignore-bound-class-methods
Schema
{
"type": "array",
"items": [
{
"type": "string",
"enum": [
"always",
"never"
]
},
{
"type": "string",
"enum": [
"ignore-interfaces"
]
}
],
"additionalItems": false
}
For more information see this page.
Type assertion on object literals is forbidden, use a type annotation instead. Open
({
check: false,
reactDocgen: 'react-docgen-typescript',
} as TypescriptConfig),
- Read upRead up
- Exclude checks
Rule: no-object-literal-type-assertion
Forbids an object literal to appear in a type assertion expression.
Casting to any
or to unknown
is still allowed.
Rationale
Always prefer const x: T = { ... };
to const x = { ... } as T;
.
The type assertion in the latter case is either unnecessary or hides an error.
The compiler will warn for excess properties with this syntax, but not missing required fields.
For example: const x: { foo: number } = {}
will fail to compile, but
const x = {} as { foo: number }
will succeed.
Additionally, the const assertion const x = { foo: 1 } as const
,
introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.
Notes
- TypeScript Only
Config
One option may be configured:
-
allow-arguments
allows type assertions to be used on object literals inside call expressions.
Examples
"no-object-literal-type-assertion": true
"no-object-literal-type-assertion": true,[object Object]
Schema
{
"type": "object",
"properties": {
"allow-arguments": {
"type": "boolean"
}
},
"additionalProperties": false
}
For more information see this page.
unused expression, expected an assignment or function call Open
import type { TypescriptConfig } from '@storybook/core-common';
- Read upRead up
- Exclude checks
Rule: no-unused-expression
Disallows unused expression statements.
Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).
Rationale
Detects potential errors where an assignment or function call was intended.
Config
Three arguments may be optionally provided:
-
allow-fast-null-checks
allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g.e && e.preventDefault()
). -
allow-new
allows 'new' expressions for side effects (e.g.new ModifyGlobalState();
. -
allow-tagged-template
allows tagged templates for side effects (e.g.this.add\
foo`;`.
Examples
"no-unused-expression": true
"no-unused-expression": true,allow-fast-null-checks
Schema
{
"type": "array",
"items": {
"type": "string",
"enum": [
"allow-fast-null-checks",
"allow-new",
"allow-tagged-template"
]
},
"minLength": 0,
"maxLength": 3
}
For more information see this page.