fbredius/storybook

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        {
          args: { x: '2', z: '2', obj: { a: '2', c: '2' } },
          argTypes: { x: '2', z: '2', obj: { a: '2', c: '2' } },
          globals: { x: '2', z: '2', obj: { a: '2', c: '2' } },
          globalTypes: { x: '2', z: '2', obj: { a: '2', c: '2' } },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        {
          args: { x: '1', y: '1', obj: { a: '1', b: '1' } },
          argTypes: { x: '1', y: '1', obj: { a: '1', b: '1' } },
          globals: { x: '1', y: '1', obj: { a: '1', b: '1' } },
          globalTypes: { x: '1', y: '1', obj: { a: '1', b: '1' } },

• Read up
  Read up

File detect.test.ts has 364 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import fs from 'fs';

import { getBowerJson } from './helpers';
import { isStorybookInstalled, detectFrameworkPreset, detect, detectLanguage } from './detect';
import { ProjectType, SUPPORTED_FRAMEWORKS, SupportedLanguage } from './project_types';

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('with global allowFunction true', () => {
    const channel = createChannel();

    const allowFunction = true;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('with global allowFunction false', () => {
    const channel = createChannel();

    const allowFunction = false;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('when used with a custom react-scripts package', () => {
    beforeEach(() => {
      (fs.realpathSync as unknown as jest.Mock).mockImplementationOnce((filePath) =>
        filePath.replace(SCRIPT_PATH, `custom-react-scripts/${SCRIPT_PATH}`)
      );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      <TabsState initial="test2">
        <div id="test1" title="With a function" color="#e00000">
          {({ active, selected }: { active: boolean; selected: string }) =>
            active ? <div>{selected} is selected</div> : null
          }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('when used with the default react-scripts package', () => {
    beforeEach(() => {
      (fs.realpathSync as unknown as jest.Mock).mockImplementationOnce((filePath) =>
        filePath.replace(SCRIPT_PATH, `react-scripts/${SCRIPT_PATH}`)
      );

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      <TabsState initial="test2" backgroundColor="rgba(0,0,0,.05)">
        <div id="test1" title="With a function" color="#e00000">
          {({ active, selected }: { active: boolean; selected: string }) =>
            active ? <div>{selected} is selected</div> : null
          }

• Read up
  Read up

File CsfFile.ts has 362 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* eslint-disable no-underscore-dangle */
import fs from 'fs-extra';
import dedent from 'ts-dedent';
import * as t from '@babel/types';
import generate from '@babel/generator';

Similar blocks of code found in 3 locations. Consider refactoring.

Open

const checkWebpack5 = async ({ packageJson, main }) => {
  // eslint-disable-next-line global-require
  require('fs-extra').__setMockFiles({
    [path.join('.storybook', 'main.js')]: `module.exports = ${JSON.stringify(main)};`,
  });

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

export const createPage = ({ user, onLogout, onLogin, onCreateAccount }: PageProps) => {
  const article = document.createElement('article');

  const header = createHeader({ onLogin, onLogout, onCreateAccount, user });
  article.appendChild(header);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should support multiline @returns description', () => {
      const { extractedTags } = parseJsDoc(
        '@returns {string} - This is\na multiline\ndescription\n'
      );

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

const checkCra5 = async ({ packageJson, main }) => {
  // eslint-disable-next-line global-require
  require('fs-extra').__setMockFiles({
    [path.join('.storybook', 'main.js')]: `module.exports = ${JSON.stringify(main)};`,
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it('should return a @returns with a type and a description', () => {
      const { extractedTags } = parseJsDoc('@returns {string} - A bar description');

      expect(extractedTags.returns).not.toBeNull();
      expect(extractedTags.returns.type).not.toBeNull();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

export const createPage = ({ user, onLogout, onLogin, onCreateAccount }: PageProps) => {
  const article = document.createElement('article');

  const header = createHeader({ onLogin, onLogout, onCreateAccount, user });
  article.appendChild(header);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const App: FunctionComponent = () => {
  return (
    <div className="App">
      <header className="App-header">
        <img src={logo} className="App-logo" alt="logo" />

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

const checkCra5 = async ({ packageJson, main }) => {
  // eslint-disable-next-line global-require
  require('fs-extra').__setMockFiles({
    [path.join('.storybook', 'main.js')]: `module.exports = ${JSON.stringify(main)};`,
  });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const App: FunctionComponent<{}> = () => {
  return (
    <div className="App">
      <header className="App-header">
        <img src={logo} className="App-logo" alt="logo" />

• Read up
  Read up

File prop-types.js has 360 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* eslint-disable react/no-unused-prop-types */
import React from 'react';
import PropTypes, { string, shape } from 'prop-types';
import momentPropTypes from 'react-moment-proptypes';
import { PRESET_SHAPE, SOME_PROP_TYPES } from './ext';