fbredius/storybook

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const _findVarInitialization = (identifier: string, program: t.Program) => {
  let init: t.Expression = null;
  let declarations: t.VariableDeclarator[] = null;
  program.body.find((node: t.Node) => {
    if (t.isVariableDeclaration(node)) {

• Read up
  Read up

Function render has 280 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  render() {
    const { data, name, keyPath, deep } = this.state;
    const {
      isCollapsed,
      handleRemove,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const createHeader = ({ user, onLogout, onLogin, onCreateAccount }: HeaderProps) => {
  const header = document.createElement('header');

  const wrapper = document.createElement('div');
  wrapper.className = 'wrapper';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const createHeader = ({ user, onLogout, onLogin, onCreateAccount }: HeaderProps) => {
  const header = document.createElement('header');

  const wrapper = document.createElement('div');
  wrapper.className = 'wrapper';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const validateArgs = (key = '', value: unknown): boolean => {
  if (key === null) return false;
  if (key === '' || !VALIDATION_REGEXP.test(key)) return false;
  if (value === null || value === undefined) return true; // encoded as `!null` or `!undefined`
  if (value instanceof Date) return true; // encoded as modified ISO string

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const validateArgs = (key = '', value: unknown): boolean => {
  if (key === null) return false;
  if (key === '' || !VALIDATION_REGEXP.test(key)) return false;
  if (value === null || value === undefined) return true; // encoded as `!null` or `!undefined`
  if (value instanceof Date) return true; // encoded as modified ISO string

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('passes loaded context to renderToDOM', async () => {
        document.location.search = '?id=component-one--a';
        await createAndRenderPreview();

        mockChannel.emit.mockClear();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('latestVersion', () => {
    it('without constraint it returns the latest version', async () => {
      const executeCommandSpy = jest.spyOn(npmProxy, 'executeCommand').mockReturnValue('"5.3.19"');

      const version = await npmProxy.latestVersion('@storybook/addons');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('latestVersion', () => {
    it('without constraint it returns the latest version', async () => {
      const executeCommandSpy = jest
        .spyOn(yarn1Proxy, 'executeCommand')
        .mockReturnValue('{"type":"inspect","data":"5.3.19"}');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it('passes loaded context to renderToDOM', async () => {
        document.location.search = '?id=component-one--a&viewMode=docs';
        await createAndRenderPreview();

        mockChannel.emit.mockClear();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  if (options.cache) {
    // Retrieve the Storybook version number to bust cache on upgrades.
    const packageFile = await findUp('package.json', { cwd: __dirname });
    const { version: storybookVersion } = await fs.readJSON(packageFile);
    const cacheKey = `managerConfig-webpack${WEBPACK_VERSION}@${storybookVersion}`;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  if (options.cache) {
    // Retrieve the Storybook version number to bust cache on upgrades.
    const packageFile = await findUp('package.json', { cwd: __dirname });
    const { version: storybookVersion } = await fs.readJSON(packageFile);
    const cacheKey = `managerConfig-webpack${WEBPACK_VERSION}@${storybookVersion}`;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('render function', () => {
      it('implicit render function', () => {
        const storyObj = {};
        const meta = { title: 'title' };
        const normalized = normalizeStory('storyExport', storyObj, meta);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe('play function', () => {
      it('no render function', () => {
        const storyObj = {};
        const meta = { title: 'title' };
        const normalized = normalizeStory('storyExport', storyObj, meta);

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

PropsWriter.propTypes = {
  numberRequired: PropTypes.number.isRequired,
  numberOptional: PropTypes.number,
  stringRequired: PropTypes.string.isRequired,
  stringOptional: PropTypes.string,

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

PropsWriter.propTypes = {
  numberRequired: PropTypes.number.isRequired,
  numberOptional: PropTypes.number,
  stringRequired: PropTypes.string.isRequired,
  stringOptional: PropTypes.string,

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

PropsWriter.propTypes = {
  numberRequired: PropTypes.number.isRequired,
  numberOptional: PropTypes.number,
  stringRequired: PropTypes.string.isRequired,
  stringOptional: PropTypes.string,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

describe('server.getPreviewHeadHtml', () => {
  describe('when .storybook/preview-head.html does not exist', () => {
    beforeEach(() => {
      mock({
        [`undefined/templates/base-preview-head.html`]: BASE_HTML_CONTENTS,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

describe('server.getPreviewBodyHtml', () => {
  describe('when .storybook/preview-body.html does not exist', () => {
    beforeEach(() => {
      mock({
        [`undefined/templates/base-preview-body.html`]: BASE_BODY_HTML_CONTENTS,

• Read up
  Read up

File PreviewWeb.tsx has 586 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import deprecate from 'util-deprecate';
import dedent from 'ts-dedent';
import global from 'global';
import { SynchronousPromise } from 'synchronous-promise';
import Events, { IGNORED_EXCEPTION } from '@storybook/core-events';