fbredius/storybook

View on GitHub
lib/api/src/index.tsx

Summary

Maintainability
D
1 day
Test Coverage

File index.tsx has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, {
  Component,
  Fragment,
  FunctionComponent,
  ReactElement,
Severity: Minor
Found in lib/api/src/index.tsx - About 5 hrs to fix

    Function useSharedState has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function useSharedState<S>(stateId: string, defaultState?: S) {
      const api = useStorybookApi();
      const existingState = api.getAddonState<S>(stateId);
      const state = orDefault<S>(
        existingState,
    Severity: Major
    Found in lib/api/src/index.tsx - About 2 hrs to fix

      Function constructor has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(props: ManagerProviderProps) {
          super(props);
          const {
            location,
            path,
      Severity: Minor
      Found in lib/api/src/index.tsx - About 2 hrs to fix

        Function useSharedState has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        export function useSharedState<S>(stateId: string, defaultState?: S) {
          const api = useStorybookApi();
          const existingState = api.getAddonState<S>(stateId);
          const state = orDefault<S>(
            existingState,
        Severity: Minor
        Found in lib/api/src/index.tsx - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function allListeners has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const allListeners = useMemo(() => {
            const stateChangeHandlers = {
              [`${SHARED_STATE_CHANGED}-client-${stateId}`]: (s: S) => setState(s),
              [`${SHARED_STATE_SET}-client-${stateId}`]: (s: S) => setState(s),
            };
        Severity: Minor
        Found in lib/api/src/index.tsx - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            useEffect(() => {
              Object.entries(eventMap).forEach(([type, listener]) => api.on(type, listener));
              return () => {
                Object.entries(eventMap).forEach(([type, listener]) => api.off(type, listener));
              };
          Severity: Major
          Found in lib/api/src/index.tsx and 1 other location - About 2 hrs to fix
          lib/addons/src/hooks.ts on lines 395..402

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              const stateChangeHandlers = {
                [`${SHARED_STATE_CHANGED}-client-${stateId}`]: (s: S) => setState(s),
                [`${SHARED_STATE_SET}-client-${stateId}`]: (s: S) => setState(s),
              };
          Severity: Major
          Found in lib/api/src/index.tsx and 1 other location - About 1 hr to fix
          lib/store/src/hooks.ts on lines 47..50

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Shadowed name: 'type'
          Open

                Object.entries(eventMap).forEach(([type, listener]) => api.off(type, listener));
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-shadowed-variable

          Disallows shadowing variable declarations.

          Rationale

          When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

          const a = 'no shadow';
          function print() {
              console.log(a);
          }
          print(); // logs 'no shadow'.
          const a = 'no shadow';
          function print() {
              const a = 'shadow'; // TSLint will complain here.
              console.log(a);
          }
          print(); // logs 'shadow'.

          ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

          Config

          You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

          The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

          The following example shows how the "temporalDeadZone" option changes the linting result:

          function fn(value) {
              if (value) {
                  const tmp = value; // no error on this line if "temporalDeadZone" is false
                  return tmp;
              }
              let tmp = undefined;
              if (!value) {
                  const tmp = value; // this line always contains an error
                  return tmp;
              }
          }
          Examples
          "no-shadowed-variable": true
          "no-shadowed-variable": true,[object Object]
          Schema
          {
            "type": "object",
            "properties": {
              "class": {
                "type": "boolean"
              },
              "enum": {
                "type": "boolean"
              },
              "function": {
                "type": "boolean"
              },
              "import": {
                "type": "boolean"
              },
              "interface": {
                "type": "boolean"
              },
              "namespace": {
                "type": "boolean"
              },
              "typeAlias": {
                "type": "boolean"
              },
              "typeParameter": {
                "type": "boolean"
              },
              "temporalDeadZone": {
                "type": "boolean"
              },
              "underscore": {
                "type": "boolean"
              }
            }
          }

          For more information see this page.

          Type assertion on object literals is forbidden, use a type annotation instead.
          Open

            api: API = {} as API;
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-object-literal-type-assertion

          Forbids an object literal to appear in a type assertion expression. Casting to any or to unknown is still allowed.

          Rationale

          Always prefer const x: T = { ... }; to const x = { ... } as T;. The type assertion in the latter case is either unnecessary or hides an error. The compiler will warn for excess properties with this syntax, but not missing required fields. For example: const x: { foo: number } = {} will fail to compile, but const x = {} as { foo: number } will succeed. Additionally, the const assertion const x = { foo: 1 } as const, introduced in TypeScript 3.4, is considered beneficial and is ignored by this rule.

          Notes
          • TypeScript Only

          Config

          One option may be configured:

          • allow-arguments allows type assertions to be used on object literals inside call expressions.
          Examples
          "no-object-literal-type-assertion": true
          "no-object-literal-type-assertion": true,[object Object]
          Schema
          {
            "type": "object",
            "properties": {
              "allow-arguments": {
                "type": "boolean"
              }
            },
            "additionalProperties": false
          }

          For more information see this page.

          Missing semicolon
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          statements are not aligned
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: align

          Enforces vertical alignment.

          Rationale

          Helps maintain a readable, consistent style in your codebase.

          Consistent alignment for code statements helps keep code readable and clear. Statements misaligned from the standard can be harder to read and understand.

          Notes
          • Has Fix

          Config

          Five arguments may be optionally provided:

          • "parameters" checks alignment of function parameters.
          • "arguments" checks alignment of function call arguments.
          • "statements" checks alignment of statements.
          • "members" checks alignment of members of classes, interfaces, type literal, object literals and object destructuring.
          • "elements" checks alignment of elements of array literals, array destructuring and tuple types.
          Examples
          "align": true,parameters,statements
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "arguments",
                "elements",
                "members",
                "parameters",
                "statements"
              ]
            },
            "minLength": 1,
            "maxLength": 5
          }

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          Missing semicolon
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          Missing semicolon
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          Unnecessary semicolon
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          Missing semicolon
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          Missing semicolon
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          Unnecessary semicolon
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          Missing semicolon
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          Missing semicolon
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          Unnecessary semicolon
          Open

            };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: semicolon

          Enforces consistent semicolon usage at the end of every statement.

          Notes
          • Has Fix

          Config

          One of the following arguments must be provided:

          • "always" enforces semicolons at the end of every statement.
          • "never" disallows semicolons at the end of every statement except for when they are necessary.

          The following arguments may be optionally provided:

          • "ignore-interfaces" skips checking semicolons at the end of interface members.
          • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
          • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
          Examples
          "semicolon": true,always
          "semicolon": true,never
          "semicolon": true,always,ignore-interfaces
          "semicolon": true,always,ignore-bound-class-methods
          Schema
          {
            "type": "array",
            "items": [
              {
                "type": "string",
                "enum": [
                  "always",
                  "never"
                ]
              },
              {
                "type": "string",
                "enum": [
                  "ignore-interfaces"
                ]
              }
            ],
            "additionalItems": false
          }

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          import type { StoriesHash, Story, Root, Group } from './lib/stories';
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          Shadowed name: 'type'
          Open

              Object.entries(eventMap).forEach(([type, listener]) => api.on(type, listener));
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-shadowed-variable

          Disallows shadowing variable declarations.

          Rationale

          When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

          const a = 'no shadow';
          function print() {
              console.log(a);
          }
          print(); // logs 'no shadow'.
          const a = 'no shadow';
          function print() {
              const a = 'shadow'; // TSLint will complain here.
              console.log(a);
          }
          print(); // logs 'shadow'.

          ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

          Config

          You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

          The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

          The following example shows how the "temporalDeadZone" option changes the linting result:

          function fn(value) {
              if (value) {
                  const tmp = value; // no error on this line if "temporalDeadZone" is false
                  return tmp;
              }
              let tmp = undefined;
              if (!value) {
                  const tmp = value; // this line always contains an error
                  return tmp;
              }
          }
          Examples
          "no-shadowed-variable": true
          "no-shadowed-variable": true,[object Object]
          Schema
          {
            "type": "object",
            "properties": {
              "class": {
                "type": "boolean"
              },
              "enum": {
                "type": "boolean"
              },
              "function": {
                "type": "boolean"
              },
              "import": {
                "type": "boolean"
              },
              "interface": {
                "type": "boolean"
              },
              "namespace": {
                "type": "boolean"
              },
              "typeAlias": {
                "type": "boolean"
              },
              "typeParameter": {
                "type": "boolean"
              },
              "temporalDeadZone": {
                "type": "boolean"
              },
              "underscore": {
                "type": "boolean"
              }
            }
          }

          For more information see this page.

          unused expression, expected an assignment or function call
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: no-unused-expression

          Disallows unused expression statements.

          Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

          Rationale

          Detects potential errors where an assignment or function call was intended.

          Config

          Three arguments may be optionally provided:

          • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
          • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
          • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
          Examples
          "no-unused-expression": true
          "no-unused-expression": true,allow-fast-null-checks
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "allow-fast-null-checks",
                "allow-new",
                "allow-tagged-template"
              ]
            },
            "minLength": 0,
            "maxLength": 3
          }

          For more information see this page.

          statements are not aligned
          Open

          export type { Options as StoreOptions, Listener as ChannelListener };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: align

          Enforces vertical alignment.

          Rationale

          Helps maintain a readable, consistent style in your codebase.

          Consistent alignment for code statements helps keep code readable and clear. Statements misaligned from the standard can be harder to read and understand.

          Notes
          • Has Fix

          Config

          Five arguments may be optionally provided:

          • "parameters" checks alignment of function parameters.
          • "arguments" checks alignment of function call arguments.
          • "statements" checks alignment of statements.
          • "members" checks alignment of members of classes, interfaces, type literal, object literals and object destructuring.
          • "elements" checks alignment of elements of array literals, array destructuring and tuple types.
          Examples
          "align": true,parameters,statements
          Schema
          {
            "type": "array",
            "items": {
              "type": "string",
              "enum": [
                "arguments",
                "elements",
                "members",
                "parameters",
                "statements"
              ]
            },
            "minLength": 1,
            "maxLength": 5
          }

          For more information see this page.

          Do not use comma operator here because it can be easily misunderstood or lead to unintended bugs.
          Open

          export type { StoriesHash, Story, Root, Group };
          Severity: Minor
          Found in lib/api/src/index.tsx by tslint

          Rule: ban-comma-operator

          Disallows the comma operator to be used.

          Read more about the comma operator here.

          Rationale

          Using the comma operator can create a potential for many non-obvious bugs or lead to misunderstanding of code.

          Examples

          foo((bar, baz)); // evaluates to 'foo(baz)' because of the extra parens - confusing and not obvious
          switch (foo) {
              case 1, 2: // equals 'case 2' - probably intended 'case 1: case2:'
                  return true;
              case 3:
                  return false;
          }
          let x = (y = 1, z = 2); // x is equal to 2 - this may not be immediately obvious.
          Examples
          "ban-comma-operator": true

          For more information see this page.

          There are no issues that match your filters.

          Category
          Status