Sign upLogin

fbredius/storybook

View on GitHub
Star
lib/csf-tools/src/getStorySortParameter.test.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('invalid parameters', () => {
      expect(() =>
        getStorySortParameter(dedent`
          export const parameters = [];
        `)
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 2 other locations - About 40 mins to fix
lib/csf-tools/src/getStorySortParameter.test.ts on lines 166..189
lib/csf-tools/src/getStorySortParameter.test.ts on lines 191..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('options var', () => {
      expect(() =>
        getStorySortParameter(dedent`
          const options = {
            storySort: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 2 other locations - About 40 mins to fix
lib/csf-tools/src/getStorySortParameter.test.ts on lines 133..147
lib/csf-tools/src/getStorySortParameter.test.ts on lines 191..214

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    it('storySort var', () => {
      expect(() =>
        getStorySortParameter(dedent`
          const storySort = {
            method: "",
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 2 other locations - About 40 mins to fix
lib/csf-tools/src/getStorySortParameter.test.ts on lines 133..147
lib/csf-tools/src/getStorySortParameter.test.ts on lines 166..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

    it('function', () => {
      expect(
        getStorySortParameter(dedent`
          export const parameters = {
            options: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 24 other locations - About 35 mins to fix
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 16..32
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 34..56
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 58..78
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 80..90
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 92..109
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 111..128
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 130..149
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 151..179
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 181..204
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 206..226
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 230..250
lib/csf-tools/src/CsfFile.test.ts on lines 96..116
lib/csf-tools/src/CsfFile.test.ts on lines 118..135
lib/csf-tools/src/CsfFile.test.ts on lines 137..153
lib/csf-tools/src/CsfFile.test.ts on lines 155..174
lib/csf-tools/src/CsfFile.test.ts on lines 176..195
lib/csf-tools/src/CsfFile.test.ts on lines 197..217
lib/csf-tools/src/CsfFile.test.ts on lines 219..238
lib/csf-tools/src/CsfFile.test.ts on lines 336..354
lib/csf-tools/src/CsfFile.test.ts on lines 435..453
lib/csf-tools/src/getStorySortParameter.test.ts on lines 24..54
lib/csf-tools/src/getStorySortParameter.test.ts on lines 56..69
lib/csf-tools/src/getStorySortParameter.test.ts on lines 87..107
lib/csf-tools/src/getStorySortParameter.test.ts on lines 109..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

    it('arrow function', () => {
      expect(
        getStorySortParameter(dedent`
          export const parameters = {
            options: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 24 other locations - About 35 mins to fix
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 16..32
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 34..56
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 58..78
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 80..90
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 92..109
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 111..128
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 130..149
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 151..179
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 181..204
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 206..226
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 230..250
lib/csf-tools/src/CsfFile.test.ts on lines 96..116
lib/csf-tools/src/CsfFile.test.ts on lines 118..135
lib/csf-tools/src/CsfFile.test.ts on lines 137..153
lib/csf-tools/src/CsfFile.test.ts on lines 155..174
lib/csf-tools/src/CsfFile.test.ts on lines 176..195
lib/csf-tools/src/CsfFile.test.ts on lines 197..217
lib/csf-tools/src/CsfFile.test.ts on lines 219..238
lib/csf-tools/src/CsfFile.test.ts on lines 336..354
lib/csf-tools/src/CsfFile.test.ts on lines 435..453
lib/csf-tools/src/getStorySortParameter.test.ts on lines 24..54
lib/csf-tools/src/getStorySortParameter.test.ts on lines 71..85
lib/csf-tools/src/getStorySortParameter.test.ts on lines 87..107
lib/csf-tools/src/getStorySortParameter.test.ts on lines 109..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

    it('empty sort', () => {
      expect(
        getStorySortParameter(dedent`
          export const parameters = {
            options: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 24 other locations - About 35 mins to fix
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 16..32
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 34..56
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 58..78
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 80..90
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 92..109
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 111..128
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 130..149
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 151..179
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 181..204
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 206..226
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 230..250
lib/csf-tools/src/CsfFile.test.ts on lines 96..116
lib/csf-tools/src/CsfFile.test.ts on lines 118..135
lib/csf-tools/src/CsfFile.test.ts on lines 137..153
lib/csf-tools/src/CsfFile.test.ts on lines 155..174
lib/csf-tools/src/CsfFile.test.ts on lines 176..195
lib/csf-tools/src/CsfFile.test.ts on lines 197..217
lib/csf-tools/src/CsfFile.test.ts on lines 219..238
lib/csf-tools/src/CsfFile.test.ts on lines 336..354
lib/csf-tools/src/CsfFile.test.ts on lines 435..453
lib/csf-tools/src/getStorySortParameter.test.ts on lines 24..54
lib/csf-tools/src/getStorySortParameter.test.ts on lines 56..69
lib/csf-tools/src/getStorySortParameter.test.ts on lines 71..85
lib/csf-tools/src/getStorySortParameter.test.ts on lines 109..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

    it('parameters typescript', () => {
      expect(
        getStorySortParameter(dedent`
          export const parameters = {
            options: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 24 other locations - About 35 mins to fix
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 16..32
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 34..56
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 58..78
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 80..90
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 92..109
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 111..128
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 130..149
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 151..179
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 181..204
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 206..226
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 230..250
lib/csf-tools/src/CsfFile.test.ts on lines 96..116
lib/csf-tools/src/CsfFile.test.ts on lines 118..135
lib/csf-tools/src/CsfFile.test.ts on lines 137..153
lib/csf-tools/src/CsfFile.test.ts on lines 155..174
lib/csf-tools/src/CsfFile.test.ts on lines 176..195
lib/csf-tools/src/CsfFile.test.ts on lines 197..217
lib/csf-tools/src/CsfFile.test.ts on lines 219..238
lib/csf-tools/src/CsfFile.test.ts on lines 336..354
lib/csf-tools/src/CsfFile.test.ts on lines 435..453
lib/csf-tools/src/getStorySortParameter.test.ts on lines 24..54
lib/csf-tools/src/getStorySortParameter.test.ts on lines 56..69
lib/csf-tools/src/getStorySortParameter.test.ts on lines 71..85
lib/csf-tools/src/getStorySortParameter.test.ts on lines 87..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 25 locations. Consider refactoring.
Open

    it('with wildcards', () => {
      expect(
        getStorySortParameter(dedent`
          export const parameters = {
            options: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.test.ts and 24 other locations - About 35 mins to fix
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 16..32
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 34..56
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 58..78
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 80..90
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 92..109
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 111..128
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 130..149
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 151..179
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 181..204
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 206..226
lib/codemod/src/transforms/__tests__/csf-2-to-3.test.ts on lines 230..250
lib/csf-tools/src/CsfFile.test.ts on lines 96..116
lib/csf-tools/src/CsfFile.test.ts on lines 118..135
lib/csf-tools/src/CsfFile.test.ts on lines 137..153
lib/csf-tools/src/CsfFile.test.ts on lines 155..174
lib/csf-tools/src/CsfFile.test.ts on lines 176..195
lib/csf-tools/src/CsfFile.test.ts on lines 197..217
lib/csf-tools/src/CsfFile.test.ts on lines 219..238
lib/csf-tools/src/CsfFile.test.ts on lines 336..354
lib/csf-tools/src/CsfFile.test.ts on lines 435..453
lib/csf-tools/src/getStorySortParameter.test.ts on lines 56..69
lib/csf-tools/src/getStorySortParameter.test.ts on lines 71..85
lib/csf-tools/src/getStorySortParameter.test.ts on lines 87..107
lib/csf-tools/src/getStorySortParameter.test.ts on lines 109..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status