Sign upLogin

fbredius/storybook

View on GitHub
Star
lib/csf-tools/src/getStorySortParameter.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function getStorySortParameter has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const getStorySortParameter = (previewCode: string) => {
  let storySort: t.Expression;
  const ast = babelParse(previewCode);
  traverse(ast, {
    ExportNamedDeclaration: {
Severity: Major
Found in lib/csf-tools/src/getStorySortParameter.ts - About 2 hrs to fix

    Function enter has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          enter({ node }) {
        if (t.isVariableDeclaration(node.declaration)) {
          node.declaration.declarations.forEach((decl) => {
            if (t.isVariableDeclarator(decl) && t.isIdentifier(decl.id)) {
              const { name: exportName } = decl.id;
    Severity: Minor
    Found in lib/csf-tools/src/getStorySortParameter.ts - About 1 hr to fix

      Function getStorySortParameter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export const getStorySortParameter = (previewCode: string) => {
  let storySort: t.Expression;
  const ast = babelParse(previewCode);
  traverse(ast, {
    ExportNamedDeclaration: {
      Severity: Minor
      Found in lib/csf-tools/src/getStorySortParameter.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                        if (options) {
                    if (t.isObjectExpression(options)) {
                      storySort = getValue(options, 'storySort');
                    } else {
                      unsupported('options', true);
      Severity: Major
      Found in lib/csf-tools/src/getStorySortParameter.ts - About 45 mins to fix

        Function parseValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        const parseValue = (expr: t.Expression): any => {
  if (t.isArrayExpression(expr)) {
    return expr.elements.map((o: t.Expression) => {
      return parseValue(o);
    });
        Severity: Minor
        Found in lib/csf-tools/src/getStorySortParameter.ts - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

          return unsupported('storySort', true);
        Severity: Major
        Found in lib/csf-tools/src/getStorySortParameter.ts - About 30 mins to fix

          forbidden eval
          Open

              return eval(wrapper);
          Severity: Minor
          Found in lib/csf-tools/src/getStorySortParameter.ts by tslint

          Rule: no-eval

          Disallows eval function invocations.

          Rationale

          eval() is dangerous as it allows arbitrary code execution with full privileges. There are alternatives for most of the use cases for eval().

          Config

          Not configurable.

          Examples
          "no-eval": true

          For more information see this page.

          forbidden eval
          Open

              return eval(sortCode);
          Severity: Minor
          Found in lib/csf-tools/src/getStorySortParameter.ts by tslint

          Rule: no-eval

          Disallows eval function invocations.

          Rationale

          eval() is dangerous as it allows arbitrary code execution with full privileges. There are alternatives for most of the use cases for eval().

          Config

          Not configurable.

          Examples
          "no-eval": true

          For more information see this page.

          There are no issues that match your filters.

          Category
          Status