fbredius/storybook

View on GitHub
lib/ui/src/components/layout/mobile.tsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const { Sidebar, Preview, Panel, Notifications, pages, viewMode, options, docsOnly } =
      this.props;

    const { active } = this.state;
Severity: Minor
Found in lib/ui/src/components/layout/mobile.tsx - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return {};
    Severity: Major
    Found in lib/ui/src/components/layout/mobile.tsx - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  {pages.map(({ key, route: Route, render: Content }) => (
                    <Route key={key}>
                      <Content />
                    </Route>
                  ))}
      Severity: Major
      Found in lib/ui/src/components/layout/mobile.tsx and 1 other location - About 1 hr to fix
      lib/ui/src/components/layout/desktop.tsx on lines 69..73

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <TabButton onClick={() => this.setState({ active: SIDEBAR })} active={active === SIDEBAR}>
                  Sidebar
                </TabButton>
      Severity: Minor
      Found in lib/ui/src/components/layout/mobile.tsx and 1 other location - About 35 mins to fix
      lib/ui/src/components/layout/mobile.tsx on lines 200..202

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  <TabButton onClick={() => this.setState({ active: ADDONS })} active={active === ADDONS}>
                    Addons
                  </TabButton>
      Severity: Minor
      Found in lib/ui/src/components/layout/mobile.tsx and 1 other location - About 35 mins to fix
      lib/ui/src/components/layout/mobile.tsx on lines 190..192

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      " should be '
      Open

                    <Preview isToolshown={options.isToolshown} id="main" viewMode={viewMode} />

      Rule: quotemark

      Enforces quote character for string literals.

      Notes
      • Has Fix

      Config

      Five arguments may be optionally provided:

      • "single" enforces single quotes.
      • "double" enforces double quotes.
      • "backtick" enforces backticks.
      • "jsx-single" enforces single quotes for JSX attributes.
      • "jsx-double" enforces double quotes for JSX attributes.
      • "avoid-template" forbids single-line untagged template strings that do not contain string interpolations. Note that backticks may still be used if "avoid-escape" is enabled and both single and double quotes are present in the string (the latter option takes precedence).
      • "avoid-escape" allows you to use the "other" quotemark in cases where escaping would normally be required. For example, [true, "double", "avoid-escape"] would not report a failure on the string literal 'Hello "World"'.
      Examples
      "quotemark": true,single,avoid-escape,avoid-template
      "quotemark": true,single,jsx-double
      Schema
      {
        "type": "array",
        "items": {
          "type": "string",
          "enum": [
            "single",
            "double",
            "backtick",
            "jsx-single",
            "jsx-double",
            "avoid-escape",
            "avoid-template"
          ]
        },
        "minLength": 0,
        "maxLength": 5
      }

      For more information see this page.

      There are no issues that match your filters.

      Category
      Status