fbredius/storybook

View on GitHub
lib/ui/src/components/sidebar/useExpanded.ts

Summary

Maintainability
B
4 hrs
Test Coverage

Function navigateTree has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    const navigateTree = throttle((event: KeyboardEvent) => {
      const highlightedItemId =
        highlightedRef.current?.refId === refId && highlightedRef.current?.itemId;
      if (!isBrowsing || !containerRef.current || !highlightedItemId || event.repeat) return;
      if (!matchesModifiers(false, event)) return;
Severity: Minor
Found in lib/ui/src/components/sidebar/useExpanded.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

              return;
    Severity: Major
    Found in lib/ui/src/components/sidebar/useExpanded.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            if (!isAncestor(menuElement, target) && !isAncestor(target, menuElement)) return;
      Severity: Major
      Found in lib/ui/src/components/sidebar/useExpanded.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                if (isEnter || isSpace) return;
        Severity: Major
        Found in lib/ui/src/components/sidebar/useExpanded.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return;
          Severity: Major
          Found in lib/ui/src/components/sidebar/useExpanded.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return;
            Severity: Major
            Found in lib/ui/src/components/sidebar/useExpanded.ts - About 30 mins to fix

              Missing semicolon
              Open

              import type { StoriesHash } from '@storybook/api';

              Rule: semicolon

              Enforces consistent semicolon usage at the end of every statement.

              Notes
              • Has Fix

              Config

              One of the following arguments must be provided:

              • "always" enforces semicolons at the end of every statement.
              • "never" disallows semicolons at the end of every statement except for when they are necessary.

              The following arguments may be optionally provided:

              • "ignore-interfaces" skips checking semicolons at the end of interface members.
              • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
              • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
              Examples
              "semicolon": true,always
              "semicolon": true,never
              "semicolon": true,always,ignore-interfaces
              "semicolon": true,always,ignore-bound-class-methods
              Schema
              {
                "type": "array",
                "items": [
                  {
                    "type": "string",
                    "enum": [
                      "always",
                      "never"
                    ]
                  },
                  {
                    "type": "string",
                    "enum": [
                      "ignore-interfaces"
                    ]
                  }
                ],
                "additionalItems": false
              }

              For more information see this page.

              Missing semicolon
              Open

              import type { StoriesHash } from '@storybook/api';

              Rule: semicolon

              Enforces consistent semicolon usage at the end of every statement.

              Notes
              • Has Fix

              Config

              One of the following arguments must be provided:

              • "always" enforces semicolons at the end of every statement.
              • "never" disallows semicolons at the end of every statement except for when they are necessary.

              The following arguments may be optionally provided:

              • "ignore-interfaces" skips checking semicolons at the end of interface members.
              • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
              • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
              Examples
              "semicolon": true,always
              "semicolon": true,never
              "semicolon": true,always,ignore-interfaces
              "semicolon": true,always,ignore-bound-class-methods
              Schema
              {
                "type": "array",
                "items": [
                  {
                    "type": "string",
                    "enum": [
                      "always",
                      "never"
                    ]
                  },
                  {
                    "type": "string",
                    "enum": [
                      "ignore-interfaces"
                    ]
                  }
                ],
                "additionalItems": false
              }

              For more information see this page.

              block is empty
              Open

              const noop = () => {};

              Rule: no-empty

              Disallows empty blocks.

              Blocks with a comment inside are not considered empty.

              Rationale

              Empty blocks are often indicators of missing code.

              Config

              If allow-empty-catch is specified, then catch blocks are allowed to be empty. If allow-empty-functions is specified, then function definitions are allowed to be empty.

              Examples
              "no-empty": true
              "no-empty": true,allow-empty-catch
              "no-empty": true,allow-empty-functions
              "no-empty": true,allow-empty-catch,allow-empty-functions
              Schema
              {
                "type": "array",
                "items": {
                  "anyOf": [
                    {
                      "type": "string",
                      "enum": [
                        "allow-empty-catch"
                      ]
                    },
                    {
                      "type": "string",
                      "enum": [
                        "allow-empty-functions"
                      ]
                    }
                  ]
                }
              }

              For more information see this page.

              'Object.assign' returns the first argument. Prefer object spread if you want a new object.
              Open

                    ids.reduce((acc, id) => Object.assign(acc, { [id]: value }), { ...state }),

              Rule: prefer-object-spread

              Enforces the use of the ES2018 object spread operator over Object.assign() where appropriate.

              Rationale

              Object spread allows for better type checking and inference.

              Notes
              • Has Fix

              Config

              Not configurable.

              Examples
              "prefer-object-spread": true

              For more information see this page.

              Missing semicolon
              Open

              import type { StoriesHash } from '@storybook/api';

              Rule: semicolon

              Enforces consistent semicolon usage at the end of every statement.

              Notes
              • Has Fix

              Config

              One of the following arguments must be provided:

              • "always" enforces semicolons at the end of every statement.
              • "never" disallows semicolons at the end of every statement except for when they are necessary.

              The following arguments may be optionally provided:

              • "ignore-interfaces" skips checking semicolons at the end of interface members.
              • "ignore-bound-class-methods" skips checking semicolons at the end of bound class methods.
              • "strict-bound-class-methods" disables any special handling of bound class methods and treats them as any other assignment. This option overrides "ignore-bound-class-methods".
              Examples
              "semicolon": true,always
              "semicolon": true,never
              "semicolon": true,always,ignore-interfaces
              "semicolon": true,always,ignore-bound-class-methods
              Schema
              {
                "type": "array",
                "items": [
                  {
                    "type": "string",
                    "enum": [
                      "always",
                      "never"
                    ]
                  },
                  {
                    "type": "string",
                    "enum": [
                      "ignore-interfaces"
                    ]
                  }
                ],
                "additionalItems": false
              }

              For more information see this page.

              unused expression, expected an assignment or function call
              Open

              import type { StoriesHash } from '@storybook/api';

              Rule: no-unused-expression

              Disallows unused expression statements.

              Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

              Rationale

              Detects potential errors where an assignment or function call was intended.

              Config

              Three arguments may be optionally provided:

              • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
              • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
              • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
              Examples
              "no-unused-expression": true
              "no-unused-expression": true,allow-fast-null-checks
              Schema
              {
                "type": "array",
                "items": {
                  "type": "string",
                  "enum": [
                    "allow-fast-null-checks",
                    "allow-new",
                    "allow-tagged-template"
                  ]
                },
                "minLength": 0,
                "maxLength": 3
              }

              For more information see this page.

              'Object.assign' returns the first argument. Prefer object spread if you want a new object.
              Open

                  (acc, id) => Object.assign(acc, { [id]: id in initialExpanded ? initialExpanded[id] : true }),

              Rule: prefer-object-spread

              Enforces the use of the ES2018 object spread operator over Object.assign() where appropriate.

              Rationale

              Object spread allows for better type checking and inference.

              Notes
              • Has Fix

              Config

              Not configurable.

              Examples
              "prefer-object-spread": true

              For more information see this page.

              unused expression, expected an assignment or function call
              Open

              import type { StoriesHash } from '@storybook/api';

              Rule: no-unused-expression

              Disallows unused expression statements.

              Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

              Rationale

              Detects potential errors where an assignment or function call was intended.

              Config

              Three arguments may be optionally provided:

              • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
              • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
              • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
              Examples
              "no-unused-expression": true
              "no-unused-expression": true,allow-fast-null-checks
              Schema
              {
                "type": "array",
                "items": {
                  "type": "string",
                  "enum": [
                    "allow-fast-null-checks",
                    "allow-new",
                    "allow-tagged-template"
                  ]
                },
                "minLength": 0,
                "maxLength": 3
              }

              For more information see this page.

              unused expression, expected an assignment or function call
              Open

              import type { StoriesHash } from '@storybook/api';

              Rule: no-unused-expression

              Disallows unused expression statements.

              Unused expressions are expression statements which are not assignments or function calls (and thus usually no-ops).

              Rationale

              Detects potential errors where an assignment or function call was intended.

              Config

              Three arguments may be optionally provided:

              • allow-fast-null-checks allows to use logical operators to perform fast null checks and perform method or function calls for side effects (e.g. e && e.preventDefault()).
              • allow-new allows 'new' expressions for side effects (e.g. new ModifyGlobalState();.
              • allow-tagged-template allows tagged templates for side effects (e.g. this.add\foo`;`.
              Examples
              "no-unused-expression": true
              "no-unused-expression": true,allow-fast-null-checks
              Schema
              {
                "type": "array",
                "items": {
                  "type": "string",
                  "enum": [
                    "allow-fast-null-checks",
                    "allow-new",
                    "allow-tagged-template"
                  ]
                },
                "minLength": 0,
                "maxLength": 3
              }

              For more information see this page.

              Shadowed name: 'type'
              Open

                    const type = highlightedElement.getAttribute('data-nodetype');

              Rule: no-shadowed-variable

              Disallows shadowing variable declarations.

              Rationale

              When a variable in a local scope and a variable in the containing scope have the same name, shadowing occurs. Shadowing makes it impossible to access the variable in the containing scope and obscures to what value an identifier actually refers. Compare the following snippets:

              const a = 'no shadow';
              function print() {
                  console.log(a);
              }
              print(); // logs 'no shadow'.
              const a = 'no shadow';
              function print() {
                  const a = 'shadow'; // TSLint will complain here.
                  console.log(a);
              }
              print(); // logs 'shadow'.

              ESLint has an equivalent rule. For more background information, refer to this MDN closure doc.

              Config

              You can optionally pass an object to disable checking for certain kinds of declarations. Possible keys are "class", "enum", "function", "import", "interface", "namespace", "typeAlias" and "typeParameter". You can also pass "underscore" to ignore variable names that begin with _. Just set the value to false for the check you want to disable. All checks default to true, i.e. are enabled by default. Note that you cannot disable variables and parameters.

              The option "temporalDeadZone" defaults to true which shows errors when shadowing block scoped declarations in their temporal dead zone. When set to false parameters, classes, enums and variables declared with let or const are not considered shadowed if the shadowing occurs within their temporal dead zone.

              The following example shows how the "temporalDeadZone" option changes the linting result:

              function fn(value) {
                  if (value) {
                      const tmp = value; // no error on this line if "temporalDeadZone" is false
                      return tmp;
                  }
                  let tmp = undefined;
                  if (!value) {
                      const tmp = value; // this line always contains an error
                      return tmp;
                  }
              }
              Examples
              "no-shadowed-variable": true
              "no-shadowed-variable": true,[object Object]
              Schema
              {
                "type": "object",
                "properties": {
                  "class": {
                    "type": "boolean"
                  },
                  "enum": {
                    "type": "boolean"
                  },
                  "function": {
                    "type": "boolean"
                  },
                  "import": {
                    "type": "boolean"
                  },
                  "interface": {
                    "type": "boolean"
                  },
                  "namespace": {
                    "type": "boolean"
                  },
                  "typeAlias": {
                    "type": "boolean"
                  },
                  "typeParameter": {
                    "type": "boolean"
                  },
                  "temporalDeadZone": {
                    "type": "boolean"
                  },
                  "underscore": {
                    "type": "boolean"
                  }
                }
              }

              For more information see this page.

              There are no issues that match your filters.

              Category
              Status