Sign upLogin

fbredius/storybook

View on GitHub
Star
lib/ui/src/components/sidebar/useLastViewed.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function useLastViewed has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useLastViewed = (selection: Selection) => {
  const initialLastViewedStoryIds = useMemo((): StoryRef[] => {
    const items = store.get('lastViewedStoryIds');
    if (!items || !Array.isArray(items)) return [];
    if (!items.some((item) => typeof item === 'object' && item.storyId && item.refId)) return [];
Severity: Minor
Found in lib/ui/src/components/sidebar/useLastViewed.ts - About 1 hr to fix

    Function useLastViewed has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export const useLastViewed = (selection: Selection) => {
  const initialLastViewedStoryIds = useMemo((): StoryRef[] => {
    const items = store.get('lastViewedStoryIds');
    if (!items || !Array.isArray(items)) return [];
    if (!items.some((item) => typeof item === 'object' && item.storyId && item.refId)) return [];
    Severity: Minor
    Found in lib/ui/src/components/sidebar/useLastViewed.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use a conditional expression instead of assigning to 'lastViewedRef.current' in multiple places.
    Open

          if (index === -1) {
    Severity: Minor
    Found in lib/ui/src/components/sidebar/useLastViewed.ts by tslint

    Rule: prefer-conditional-expression

    Recommends to use a conditional expression instead of assigning to the same thing in each branch of an if statement.

    Rationale

    This reduces duplication and can eliminate an unnecessary variable declaration.

    Config

    If check-else-if is specified, the rule also checks nested if-else-if statements.

    Examples
    "prefer-conditional-expression": true
    "prefer-conditional-expression": true,check-else-if
    Schema
    {
  "type": "string",
  "enum": [
    "check-else-if"
  ]
}

    For more information see this page.

    There are no issues that match your filters.

    Category
    Status