Sign upLogin

fcce/bos

View on GitHub
Star
lib/bos_client/object.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [20/10]
Open

    def self.fetch(options = {})
      bucket = options[:bucket]
      filename = options[:filename]
      path = options[:path] || ''
      storage_class = options[:storage_class] || 'STANDARD'
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [19/10]
Open

    def save_to(path, name = nil)
      headers = {
        'host' => @bucket.bucket_host
      }
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [19/10]
Open

    def self.upload(options = {})
      bucket = options[:bucket]
      file = options[:file]
      origin_file_name = File.basename(file)
      filename = options[:filename] || origin_file_name
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for upload is too high. [18.87/15]
Open

    def self.upload(options = {})
      bucket = options[:bucket]
      file = options[:file]
      origin_file_name = File.basename(file)
      filename = options[:filename] || origin_file_name
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for fetch is too high. [18.87/15]
Open

    def self.fetch(options = {})
      bucket = options[:bucket]
      filename = options[:filename]
      path = options[:path] || ''
      storage_class = options[:storage_class] || 'STANDARD'
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
Open

      url = URI.encode("http://#{@bucket.bucket_host}/#{@file}")
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop identifies places where URI.escape can be replaced by CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case. Also this cop identifies places where URI.unescape can be replaced by CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.

Example:

# bad
URI.escape('http://example.com')
URI.encode('http://example.com')

# good
CGI.escape('http://example.com')
URI.encode_www_form([['example', 'param'], ['lang', 'en']])
URI.encode_www_form(page: 10, locale: 'en')
URI.encode_www_form_component('http://example.com')

# bad
URI.unescape(enc_uri)
URI.decode(enc_uri)

# good
CGI.unescape(enc_uri)
URI.decode_www_form(enc_uri)
URI.decode_www_form_component(enc_uri)

Unnecessary utf-8 encoding comment.
Open

# encoding: UTF-8
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

Add an empty line after magic comments.
Open

module BosClient
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Missing top-level class documentation comment.
Open

  class Object
Severity: Minor
Found in lib/bos_client/object.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status