lib/bos_client/request.rb

Summary

Maintainability
A
35 mins
Test Coverage

Assignment Branch Condition size for resolve_response is too high. [20.49/15]
Open

    def resolve_response(response)
      if response.success?
        ret = resolve_bos_resault response
        snake_hash_keys(ret)
      elsif response.timed_out?
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [15/10]
Open

    def resolve_response(response)
      if response.success?
        ret = resolve_bos_resault response
        snake_hash_keys(ret)
      elsif response.timed_out?
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [14/10]
Open

    def resolve_bos_resault(r)
      ret = if !r.body.empty?
              JSON.parse r.body, symbolize_names: true
            else
              {}
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method resolve_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def resolve_response(response)
      if response.success?
        ret = resolve_bos_resault response
        snake_hash_keys(ret)
      elsif response.timed_out?
Severity: Minor
Found in lib/bos_client/request.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
Open

      @uri = URI(URI.encode(url))
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

This cop identifies places where URI.escape can be replaced by CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case. Also this cop identifies places where URI.unescape can be replaced by CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case.

Example:

# bad
URI.escape('http://example.com')
URI.encode('http://example.com')

# good
CGI.escape('http://example.com')
URI.encode_www_form([['example', 'param'], ['lang', 'en']])
URI.encode_www_form(page: 10, locale: 'en')
URI.encode_www_form_component('http://example.com')

# bad
URI.unescape(enc_uri)
URI.decode(enc_uri)

# good
CGI.unescape(enc_uri)
URI.decode_www_form(enc_uri)
URI.decode_www_form_component(enc_uri)

Line is too long. [84/80]
Open

          raise BosClient::Error::HttpError, "HTTP request failed: #{response.code}"
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

Missing top-level class documentation comment.
Open

  class Request
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use response.code.zero? instead of response.code == 0.
Open

      elsif response.code == 0
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

This cop checks for usage of comparison operators (==, >, <) to test numbers as zero, positive, or negative. These can be replaced by their respective predicate methods. The cop can also be configured to do the reverse.

The cop disregards #nonzero? as it its value is truthy or falsey, but not true and false, and thus not always interchangeable with != 0.

The cop ignores comparisons to global variables, since they are often populated with objects which can be compared with integers, but are not themselves Interger polymorphic.

Example: EnforcedStyle: predicate (default)

# bad

foo == 0
0 > foo
bar.baz > 0

# good

foo.zero?
foo.negative?
bar.baz.positive?

Example: EnforcedStyle: comparison

# bad

foo.zero?
foo.negative?
bar.baz.positive?

# good

foo == 0
0 > foo
bar.baz > 0

Unnecessary utf-8 encoding comment.
Open

# encoding: UTF-8
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

Add an empty line after magic comments.
Open

module BosClient
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if ret[:data][:code]
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Line is too long. [82/80]
Open

          raise BosClient::Error.bos_error ret[:data][:code], ret[:data][:message]
Severity: Minor
Found in lib/bos_client/request.rb by rubocop

There are no issues that match your filters.

Category
Status