feathersjs-ecosystem/feathers-authentication-management

View on GitHub

Showing 18 of 18 total issues

AuthenticationManagementService has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

export class AuthenticationManagementService
  extends AuthenticationManagementBase<AuthenticationManagementData, AllResultTypes, AuthenticationManagementServiceOptions> {
  constructor (
    app: Application,
    options?: Partial<AuthenticationManagementServiceOptions>
Severity: Minor
Found in src/services/AuthenticationManagementService.ts - About 2 hrs to fix

    Function makeClient has 108 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

    function makeClient (app: Application, _options?: Partial<ClientOptions>): AuthenticationManagementClient {
      const options: ClientOptions = Object.assign({}, defaultOptions, _options);
    
      const {
        path
    Severity: Major
    Found in src/client.ts - About 1 hr to fix

      Function verifySignupSetPasswordWithShortToken has 6 arguments (exceeds 5 allowed). Consider refactoring.
      Open

        options: VerifySignupSetPasswordWithShortTokenOptions,
        verifyShortToken: string,
        identifyUser: IdentifyUser,
        password: string,
        notifierOptions: NotifierOptions = {},
      Severity: Minor
      Found in src/methods/verify-signup-set-password.ts - About 35 mins to fix

        Function identityChange has 6 arguments (exceeds 5 allowed). Consider refactoring.
        Open

          options: IdentityChangeOptions,
          identifyUser: IdentifyUser,
          password: string,
          changesIdentifyUser: Record<string, unknown>,
          notifierOptions: NotifierOptions = {},
        Severity: Minor
        Found in src/methods/identity-change.ts - About 35 mins to fix

          Function eraseVerifyPropsSetPassword has 6 arguments (exceeds 5 allowed). Consider refactoring.
          Open

              user: User,
              isVerified: boolean,
              verifyChanges: VerifyChanges,
              password: string,
              skipPasswordHash: boolean,
          Severity: Minor
          Found in src/methods/verify-signup-set-password.ts - About 35 mins to fix

            Function passwordChange has 6 arguments (exceeds 5 allowed). Consider refactoring.
            Open

              options: PasswordChangeOptions,
              identifyUser: IdentifyUser,
              oldPassword: string,
              password: string,
              notifierOptions: NotifierOptions = {},
            Severity: Minor
            Found in src/methods/password-change.ts - About 35 mins to fix

              Function resetPassword has 6 arguments (exceeds 5 allowed). Consider refactoring.
              Open

                options: ResetPasswordOptions,
                identifyUser: IdentifyUser,
                tokens: Tokens,
                password: string,
                notifierOptions: NotifierOptions = {},
              Severity: Minor
              Found in src/methods/reset-password.ts - About 35 mins to fix

                Function verifySignupSetPassword has 6 arguments (exceeds 5 allowed). Consider refactoring.
                Open

                  options: VerifySignupSetPasswordOptions,
                  identifyUser: IdentifyUser,
                  tokens: Tokens,
                  password: string,
                  notifierOptions: NotifierOptions = {},
                Severity: Minor
                Found in src/methods/verify-signup-set-password.ts - About 35 mins to fix

                  Function resetPwdWithShortToken has 6 arguments (exceeds 5 allowed). Consider refactoring.
                  Open

                    options: ResetPwdWithShortTokenOptions,
                    resetShortToken: string,
                    identifyUser: IdentifyUser,
                    password: string,
                    notifierOptions: NotifierOptions = {},
                  Severity: Minor
                  Found in src/methods/reset-password.ts - About 35 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return await this._verifySignupSetPasswordLong({
                              password: data.value.password,
                              token: data.value.token,
                              notifierOptions: data.notifierOptions
                            }, params);
                    Severity: Major
                    Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return await this._verifySignupSetPasswordShort({
                                password: data.value.password,
                                token: data.value.token,
                                user: data.value.user,
                                notifierOptions: data.notifierOptions
                      Severity: Major
                      Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return await this._sendResetPassword({
                                  user: data.value,
                                  notifierOptions: data.notifierOptions
                                }, params);
                        Severity: Major
                        Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return await this._passwordChange({
                                    oldPassword: data.value.oldPassword,
                                    password: data.value.password,
                                    user: data.value.user,
                                    notifierOptions: data.notifierOptions
                          Severity: Major
                          Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return await this._resetPasswordLong({
                                      password: data.value.password,
                                      token: data.value.token,
                                      notifierOptions: data.notifierOptions
                                    }, params);
                            Severity: Major
                            Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return await this._resetPasswordShort({
                                        password: data.value.password,
                                        token: data.value.token,
                                        user: data.value.user,
                                        notifierOptions: data.notifierOptions
                              Severity: Major
                              Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return this.options;
                                Severity: Major
                                Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return await this._identityChange({
                                            changes: data.value.changes,
                                            password: data.value.password,
                                            user: data.value.user,
                                            notifierOptions: data.notifierOptions
                                  Severity: Major
                                  Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return await Promise.reject(err);
                                    Severity: Major
                                    Found in src/services/AuthenticationManagementService.ts - About 30 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language