Sign upLogin

feathersjs/feathers-hooks-common

View on GitHub
Star
src/hooks/fgraphql.ts

Summary

Maintainability
D
2 days
Test Coverage

File fgraphql.ts has 354 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import type { Application, HookContext, Query } from '@feathersjs/feathers';
import makeDebug from 'debug';
import type { parse, GraphQLFieldResolver } from 'graphql';
import type { SyncContextFunction } from '../types';
import { getItems } from '../utils/get-items';
Severity: Minor
Found in src/hooks/fgraphql.ts - About 4 hrs to fix

    Function fgraphql has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function fgraphql<H extends HookContext = HookContext>(options1: FGraphQLHookOptions<H>) {
  debug('init call');
  const { parse, recordType, resolvers, runTime, query } = options1;
  let { schema } = options1;
    Severity: Major
    Found in src/hooks/fgraphql.ts - About 3 hrs to fix

      Function processRecord has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function processRecord(store: any, query: any, depth: any, rec: any, type: any, j: any): any {
  debug(`processRecord rec# ${j} typeof ${typeof rec} Type ${type}`);
  if (!rec) return; // Catch any null values from resolvers.

  const queryPropNames = Object.keys(query);
      Severity: Minor
      Found in src/hooks/fgraphql.ts - About 1 hr to fix

        Function processRecordFieldResolver has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function processRecordFieldResolver(
  store: any,
  query: any,
  depth: any,
  rec: any,
        Severity: Minor
        Found in src/hooks/fgraphql.ts - About 1 hr to fix

          Function processRecordQuery has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            store: any,
  query: any,
  depth: any,
  rec: any,
  fieldName: any,
          Severity: Major
          Found in src/hooks/fgraphql.ts - About 1 hr to fix

            Function fgraphql has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            export function fgraphql<H extends HookContext = HookContext>(options1: FGraphQLHookOptions<H>) {
  debug('init call');
  const { parse, recordType, resolvers, runTime, query } = options1;
  let { schema } = options1;
            Severity: Minor
            Found in src/hooks/fgraphql.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function convertResolverResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            function convertResolverResult(result: any, ourQuery: any, fieldName: any, type: any) {
  if (result === null || result === undefined) {
    return ourQuery.listType ? [] : null;
  }
            Severity: Minor
            Found in src/hooks/fgraphql.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function processRecordFieldResolver has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              store: any,
  query: any,
  depth: any,
  rec: any,
  fieldName: any,
            Severity: Minor
            Found in src/hooks/fgraphql.ts - About 45 mins to fix

              Function convertFieldDefinitionType has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              function convertFieldDefinitionType(fieldDefinitionType: any, errDesc: any, converted?: any): any {
  converted = converted || {
    nonNullTypeList: false,
    listType: false,
    nonNullTypeField: false,
              Severity: Minor
              Found in src/hooks/fgraphql.ts - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function processRecord has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function processRecord(store: any, query: any, depth: any, rec: any, type: any, j: any): any {
              Severity: Minor
              Found in src/hooks/fgraphql.ts - About 45 mins to fix

                Function processRecords has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function processRecords(store: any, query: any, recs: any, type: any, depth = 0): any {
                Severity: Minor
                Found in src/hooks/fgraphql.ts - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (definition.kind !== 'ObjectTypeDefinition' || !isArray(definition.fields)) {
    throw new Error(`Type# ${definitionIndex} is not a valid ObjectTypeDefinition`);
  }
                  Severity: Minor
                  Found in src/hooks/fgraphql.ts and 1 other location - About 30 mins to fix
                  src/hooks/fgraphql.ts on lines 399..401

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (field.kind !== 'FieldDefinition' || !isObject(field.type)) {
    throw new Error(`${errDesc} is not a valid ObjectTypeDefinition`);
  }
                  Severity: Minor
                  Found in src/hooks/fgraphql.ts and 1 other location - About 30 mins to fix
                  src/hooks/fgraphql.ts on lines 375..377

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status