Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star
usaspending_api/common/threaded_data_loader.py

Summary

Maintainability
B
6 hrs
Test Coverage
F
47%

Function process_data has a Cognitive Complexity of 42 (exceeds 15 allowed). Consider refactoring.
Open

    def process_data(self):
        # Make sure we weren't flagged to exit
        while True:
            row = self.data_queue.get()
            # If row is none, we need to die.
Severity: Minor
Found in usaspending_api/common/threaded_data_loader.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 10 arguments (exceeds 6 allowed). Consider refactoring.
Open

    def __init__(
Severity: Major
Found in usaspending_api/common/threaded_data_loader.py - About 1 hr to fix

    Function load_data_into_model has 7 arguments (exceeds 6 allowed). Consider refactoring.
    Open

        def load_data_into_model(self, model_instance, fields, field_map, value_map, row, logger, as_dict=False):
    Severity: Major
    Found in usaspending_api/common/threaded_data_loader.py - About 35 mins to fix

      Function load_data_into_model has a Cognitive Complexity of 17 (exceeds 15 allowed). Consider refactoring.
      Open

          def load_data_into_model(self, model_instance, fields, field_map, value_map, row, logger, as_dict=False):
        mod = model_instance

        if as_dict:
            mod = {}
      Severity: Minor
      Found in usaspending_api/common/threaded_data_loader.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status