fedspendingtransparency/usaspending-api

File backfill_per_transaction_exec_comp.py has 270 lines of code (exceeds 250 allowed). Consider refactoring.

Wontfix

"""
Jira Ticket Number(s): DEV-3331

    As a user/developer/tester I want the FABS and FPDS executive compensation data to match Broker.

Avoid deeply nested control flow statements.

Wontfix

                    if broker_fabs_data:
                        updated_row_count = run_spending_update_query(
                            SPENDING_FABS_UPDATE_SQL, "FABS", broker_fabs_data
                        )
                        fabs_row_count += updated_row_count

Avoid deeply nested control flow statements.

Wontfix

                    if broker_fpds_data:
                        updated_row_count = run_spending_update_query(
                            SPENDING_FPDS_UPDATE_SQL, "FPDS", broker_fpds_data
                        )
                        fpds_row_count += updated_row_count

Identical blocks of code found in 2 locations. Consider refactoring.

Open

class Timer:
    def __enter__(self):
        self.start = time.perf_counter()
        return self

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

def run_spending_update_query(transaction_sql, transaction_type, broker_data):
    with spending_connection.cursor() as update_cursor:
        update_query = build_spending_update_query(transaction_sql, broker_data)
        with Timer() as t:
            update_cursor.execute(update_query, [col for row in broker_data for col in row])

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

def build_spending_update_query(query_base, update_data):
    values_string = ""
    for count, row in enumerate(update_data, 1):
        values_string += "("
        values_string += ",".join(["%s"] * len(row))

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

def run_broker_select_query(transaction_sql, id_tuple):
    with broker_connection.cursor() as select_cursor:
        select_cursor.execute(transaction_sql, [id_tuple])
        return select_cursor.fetchall()

• Read up
  Read up