Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star
usaspending_api/download/v2/request_validations.py

Summary

Maintainability
D
1 day
Test Coverage
B
85%

File request_validations.py has 716 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
from copy import deepcopy
from datetime import datetime, MINYEAR, MAXYEAR
from django.conf import settings
from typing import Optional
Severity: Major
Found in usaspending_api/download/v2/request_validations.py - About 1 day to fix

    Function _handle_custom_award_download has a Cognitive Complexity of 22 (exceeds 15 allowed). Consider refactoring.
    Open

        def _handle_custom_award_download(self):
        """
        Custom Award Download allows different filters than other Award Download Endpoints
        and thus it needs to be normalized before moving forward
        # TODO: Refactor to use similar filters as Advanced Search download
    Severity: Minor
    Found in usaspending_api/download/v2/request_validations.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status