Sign upLogin

fedspendingtransparency/usaspending-api

View on GitHub
Star
usaspending_api/tests/conftest_spark.py

Summary

Maintainability
D
3 days
Test Coverage

File conftest_spark.py has 1194 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import logging
import uuid
from datetime import datetime
from pathlib import Path
Severity: Major
Found in usaspending_api/tests/conftest_spark.py - About 3 days to fix

    Cyclomatic complexity is too high in function _build_usas_data_for_spark. (37)
    Open

    def _build_usas_data_for_spark():
    """Create Django model data to be saved to Postgres, which will then get ingested into Delta Lake"""
    # Create recipient data for two transactions; the other two will generate ad hoc
    baker.make(
        "recipient.RecipientLookup",
    Severity: Minor
    Found in usaspending_api/tests/conftest_spark.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    There are no issues that match your filters.

    Category
    Status